-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Short circuit failure handling in OIDC flow #130618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 4 commits into
elastic:main
from
n1v0lg:oidc-claims-handling-tweak
Aug 4, 2025
Merged
Short circuit failure handling in OIDC flow #130618
elasticsearchmachine
merged 4 commits into
elastic:main
from
n1v0lg:oidc-claims-handling-tweak
Aug 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-security (Team:Security) |
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
…csearch into oidc-claims-handling-tweak
slobodanadamovic
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was referenced Aug 4, 2025
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Aug 4, 2025
We should return after the `onFailure` call during the claims check.
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Aug 4, 2025
We should return after the `onFailure` call during the claims check.
n1v0lg
added a commit
to n1v0lg/elasticsearch
that referenced
this pull request
Aug 4, 2025
We should return after the `onFailure` call during the claims check.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 4, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 5, 2025
…cking * upstream/main: (26 commits) [Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400) Add `TestEntitlementsRule` with support for dynamic entitled node paths for testing (elastic#132077) Reduce logging frequency for GCS per project clients (elastic#132429) Skip update/100_synthetic_source tests in yamlRestCompatTests (elastic#132296) Correct exception for missing nested path (elastic#132408) Fixing esql release tests elastic#132369 (elastic#132406) Adjust date docvalue formatting to return 4xx instead of 5xx (elastic#132414) Handle nested fields with the termvectors REST API in artificial docs (elastic#92568) Only collect bulk scored vectors when exceeding min competitive (elastic#132293) Fix release tests diskbbq update (elastic#132405) ESQL: Fix skipping of generative tests (elastic#132390) Short circuit failure handling in OIDC flow (elastic#130618) Small optimization in OptimizedScalarQuantizer by using mul instead of div (elastic#132397) Aggs: Add validation to Bucket script pipeline agg (elastic#132320) ESQL: Multiple parameters in ungrouped aggs (elastic#132375) ESQL: Explain test operators (elastic#132374) EQL: Deal with internally created IN in a different way for EQL (elastic#132167) Speed up hierarchical k-means by computing distances in bulk (elastic#132384) Reduce the number of fields per document (elastic#132322) Assert current thread in ESQL (elastic#132324) ...
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 6, 2025
We should return after the `onFailure` call during the claims check. Co-authored-by: Slobodan Adamović <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 6, 2025
We should return after the `onFailure` call during the claims check. Co-authored-by: Slobodan Adamović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>non-issue
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
v8.18.5
v8.19.1
v9.0.5
v9.1.1
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return after the
onFailure
call during the claims check.