Unmute SearchWithRandomDisconnectsIT.testSearchWithRandomDisconnects #130628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drempapis
added
>test-failure
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
needs:risk
drempapis
removed
the
needs:risk
elasticsearchmachine
added
the
needs:risk
drempapis
added
>non-issue
and removed
>test-failure
|
Hey, I don't think adding Thread.sleep is a good direction. It will only contribute to the tech debt around fixing these tests that rely on timing. I have not looked closely enough to the test to offer an alternate solution yet, but I wanted to raise that I think we should look deeper at the test and see where it relies on timing and what we can do to address that. Thanks for looking into it! |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 4, 2025
Backports the following commits to 9.1: - Unmute SearchWithRejectionsIT testOpenContextsAfterRejections (#130628)
|
Thank you, @javanna, for the feedback. You're right, I'll reiterate this test failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing test introduces network disruptions to verify search behavior under disconnect scenarios. To improve stability, I introduced a short
Thread.sleep(300)(milliseconds) after each disruption, to giveEStime to release resources and fully reconcile the cluster state. Additionally, I reduced some configuration values by an order of magnitude to make the test execute faster while preserving its effectiveness and coverage.This fix aims to address intermittent resource leak warnings. It's best to validate the change in
CI, and let the test reopen automatically if the issue reoccurs.Closes #122707