Add a checkCancelled public method to ContextIndexSearcher #130645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
PeteGillinElastic
added
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
javanna
requested changes
Jul 14, 2025
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
Thanks for opening this PR, I left a comment.
| return this.cancellable.isEnabled(); | ||
| } | ||
|
|
||
| public void checkCancelled() { |
Member
There was a problem hiding this comment.
Could you add javadocs please?
I am a bit worried that we may end up removing it in the future, because it's used only in tests. Are there other places in prod code where this method may be used perhaps? Could you comment on the fact that it's handy to have for plugins and explain the usecase so that does not get lost? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121349
Added a
checkCancelled()method toContextIndexSearcher