Show executing in pendingTasks toString output #130659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor change to make it easier to tell which task is executing.
ywangd
added
>non-issue
:Distributed Coordination/Distributed
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
|
For context, the pending tasks are logged when IT times out on waiting for relocation. It's helpful to see which task is executing in the output. I think it could also be helpful to print hot threads on timeout and we might be able to consolidate and reuse similar logic from ensureColor. I'll keep it separate from this PR though. |
DaveCTurner
approved these changes
Jul 7, 2025
|
Updated per your suggestion (51b3104). Thanks! |
ywangd
added
the
auto-merge-without-approval
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
A trivial change to make it easier to tell which task is executing. It is also consistent with the toXContent output.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
A trivial change to make it easier to tell which task is executing. It is also consistent with the toXContent output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivial change to make it easier to tell which task is executing. It is also consistent with the toXContent output.