Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented Jul 5, 2025

It is helpful to see the actual content as part of ClusterState#toString output. Such output is sometimes logged when test fails and useful for troubleshooting.

It is helpful to see the actual content as part of ClusterState#toString
output. Such output is sometimes logged when test fails and useful for
troubleshooting.
@ywangd ywangd added >non-issue :Core/Infra/Settings Settings infrastructure and APIs v9.2.0 labels Jul 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 5, 2025
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although Alexey is doing some refactoring here so we'll probably have to resolve some conflicts.

@ywangd
Copy link
Member Author

ywangd commented Jul 10, 2025

@elasticmachine update branch

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 10, 2025
@ywangd
Copy link
Member Author

ywangd commented Jul 10, 2025

Thanks for the review! I assume the conflict should be straightfoward to resolve and meanwhile the output is useful in CI failures. I hope this makes sense.

@elasticsearchmachine elasticsearchmachine merged commit 6921735 into elastic:main Jul 10, 2025
33 checks passed
@ywangd ywangd deleted the project-state-registry-to-string branch July 10, 2025 04:56
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
It is helpful to see the actual content as part of ClusterState#toString
output. Such output is sometimes logged when test fails and useful for
troubleshooting.
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
It is helpful to see the actual content as part of ClusterState#toString
output. Such output is sometimes logged when test fails and useful for
troubleshooting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Settings Settings infrastructure and APIs >non-issue Team:Core/Infra Meta label for core/infra team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants