Skip to content

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Jul 7, 2025

Disable entitlements for terminal and command tests

Fixes #130652
Fixes #130655
Fixes #130653

@mosche mosche requested a review from a team July 7, 2025 07:50
@mosche mosche added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure v9.2.0 v8.19.1 labels Jul 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mosche mosche changed the title Disable entitlements for terminal tests Disable entitlements for terminal & command tests Jul 7, 2025
@mosche
Copy link
Contributor Author

mosche commented Jul 7, 2025

@ldematte thx, could you have another look pls. Discovered there's more similar ones.

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@mosche mosche added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 7, 2025
@mosche mosche merged commit 12accdc into elastic:main Jul 8, 2025
31 of 32 checks passed
@mosche mosche deleted the entitlements/fix_terminal_tests branch July 8, 2025 08:43
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 8, 2025
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130690

@mosche
Copy link
Contributor Author

mosche commented Jul 8, 2025

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 8, 2025
(cherry picked from commit 12accdc)

# Conflicts:
#	server/src/test/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommandTests.java
#	server/src/test/java/org/elasticsearch/env/OverrideNodeVersionCommandTests.java
#	server/src/test/java/org/elasticsearch/index/shard/RemoveCorruptedShardDataCommandTests.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 8, 2025
(cherry picked from commit 12accdc)

# Conflicts:
#	server/src/test/java/org/elasticsearch/cluster/coordination/ElasticsearchNodeCommandTests.java
#	server/src/test/java/org/elasticsearch/env/OverrideNodeVersionCommandTests.java
#	server/src/test/java/org/elasticsearch/index/shard/RemoveCorruptedShardDataCommandTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.19.1 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] NodeRepurposeCommandTests class failing [CI] RemoveCorruptedShardDataCommandTests class failing [CI] TerminalTests class failing

4 participants