Skip to content

ES|QL: Fix generative tests #130692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

ES|QL: Fix generative tests #130692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,18 +539,12 @@ tests:
- class: org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT
method: test {yaml=indices.resolve_index/10_basic_resolve_index/Resolve index with hidden and closed indices}
issue: https://github.com/elastic/elasticsearch/issues/130568
- class: org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/130067
- class: org.elasticsearch.xpack.monitoring.exporter.http.HttpExporterTests
method: testExporterWithHostOnly
issue: https://github.com/elastic/elasticsearch/issues/130599
- class: org.elasticsearch.xpack.monitoring.exporter.http.HttpExporterTests
method: testCreateRestClient
issue: https://github.com/elastic/elasticsearch/issues/130600
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
method: test
issue: https://github.com/elastic/elasticsearch/issues/130067
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: test {p0=search.vectors/40_knn_search/Dimensions are dynamically set}
issue: https://github.com/elastic/elasticsearch/issues/130626
Expand Down
4 changes: 4 additions & 0 deletions ...ver/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ public static List<CsvTestsDataLoader.EnrichConfig> policiesOnKeyword(List<CsvTe
return policies.stream().filter(x -> Set.of("languages_policy").contains(x.policyName())).toList();
}

public static String randomNonVector(List<Column> previousOutput) {
return randomName(previousOutput.stream().filter(x -> x.type().contains("vector") == false).toList());
}

public static String randomName(List<Column> previousOutput) {
String result = randomRawName(previousOutput);
if (result == null) {
Expand Down
2 changes: 1 addition & 1 deletion .../java/org/elasticsearch/xpack/esql/qa/rest/generative/command/pipe/MvExpandGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public CommandDescription generate(
List<EsqlQueryGenerator.Column> previousOutput,
QuerySchema schema
) {
String toExpand = EsqlQueryGenerator.randomName(previousOutput);
String toExpand = EsqlQueryGenerator.randomNonVector(previousOutput);
if (toExpand == null) {
return EMPTY_DESCRIPTION; // no columns to expand
}
Expand Down