Skip to content

Add missing query parameters to eql.search rest-api-spec #130719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2025
Merged

Add missing query parameters to eql.search rest-api-spec #130719

merged 5 commits into from
Jul 15, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 7, 2025

Those parameters are read there:

elasticsearch/x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/plugin/RestEqlSearchAction.java

Line 56 in 6f0b262

eqlRequest.indicesOptions(IndicesOptions.fromRequest(request, eqlRequest.indicesOptions()));

elasticsearch/x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/plugin/RestEqlSearchAction.java

Line 66 in 6f0b262

eqlRequest.ccsMinimizeRoundtrips(request.paramAsBoolean("ccs_minimize_roundtrips", eqlRequest.ccsMinimizeRoundtrips()));

I've tested them manually.

@pquentin pquentin added >non-issue :Analytics/EQL EQL querying auto-backport Automatically create backport pull requests when merged v9.0.4 v8.18.4 v9.2.0 v9.1.1 v8.19.1 labels Jul 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@pquentin pquentin mentioned this pull request Jul 7, 2025
Closed
25 tasks
@luigidellaquila luigidellaquila self-requested a review July 11, 2025 08:59
luigidellaquila
luigidellaquila approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pquentin pquentin merged commit 06daf76 into elastic:main Jul 15, 2025
33 checks passed
@pquentin pquentin mentioned this pull request Jul 15, 2025
Merged
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (elastic#130719
3e11ef2 
)
@pquentin pquentin mentioned this pull request Jul 15, 2025
Merged
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (elastic#130719
7fac029 
)
@pquentin pquentin mentioned this pull request Jul 15, 2025
Merged
pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (elastic#130719
9d1db2b 
)
@pquentin pquentin mentioned this pull request Jul 15, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 8.19
✅ 9.0
✅ 8.18

pquentin added a commit to pquentin/elasticsearch that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (elastic#130719
3a267ba 
)
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (#130719) (#…
4eeb0b3 
…131264)
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (#130719) (#…
34590b6 
…131265)
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (#130719) (#…
2e65bca 
…131266)
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@pquentin
Add missing query parameters to eql.search rest-api-spec (#130719) (#…
86e9d7b 
…131267)
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@pquentin @mridula-s109
Add missing query parameters to eql.search rest-api-spec (elastic#130719
20d933c 
)
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@pquentin @mridula-s109
Add missing query parameters to eql.search rest-api-spec (elastic#130719
797fab8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

Assignees

No one assigned

Labels

:Analytics/EQL EQL querying auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pquentin @elasticsearchmachine @luigidellaquila