Add a simple query rewriter to support rewriting known match queries to semantic queries #130758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to semantic queries
kderusso
added
>refactoring
:SearchOrg/Relevance
elasticsearchmachine
added
Team:SearchOrg
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Mikep86
reviewed
Jul 7, 2025
Contributor
Mikep86
left a comment
Mikep86
left a comment
There was a problem hiding this comment.
RankFeatureShardPhase executes on the shard though, and at this point it's too late to rewrite to a semantic query as inference is performed on the coordinator node...
Member
Author
|
Closed per discussion on Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a simple query rewriter to support rewriting
matchqueries under certain known circumstances tosemanticqueries. In practice, this is planned to be used internally in theRankFeatureShardPhaseduring query rewrite time, when we want to manually create asemanticquery to correctly extract snippets in this phase where no rewrite context is accessible.