Fix and unmute SearchServiceSingleNodeTests #130787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchaplin
added
>non-issue
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Jul 8, 2025
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Jul 8, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Jul 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #126812.
This fix is specifically for
testBeforeShardLockDuringShardCreate. I'm unmuting both because I believe this failure may have leaked resources leading to other test failures.Since #123855, there's another condition that must be met in order to free the active reader contexts. The additional assertion here tests that new condition explicitly.