-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix NPE in IndexShard flushStats #130809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix NPE in IndexShard flushStats #130809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d985299
to
8695349
Compare
kingherc
commented
Jul 8, 2025
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
fcofdez
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8695349
to
f03b16f
Compare
f03b16f
to
1b772fc
Compare
Note we cannot use withEngineOrNull because the method can block and cannot be called from cluster state update threads. Fixes elastic#124164
1b772fc
to
aa84a39
Compare
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 10, 2025
This was referenced Jul 10, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 10, 2025
kingherc
added a commit
to kingherc/elasticsearch
that referenced
this pull request
Jul 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
Team:Distributed Indexing
Meta label for Distributed Indexing team
>test
Issues or PRs that are addressing/adding tests
v8.18.5
v8.19.1
v9.0.5
v9.1.1
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124164