Check file entitlements on the Lucene FilterFileSystem in tests #130825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosche
added
:Core/Infra/Entitlements
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
reviewed
Jul 8, 2025
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PathLookupImpl.java
Outdated
Show resolved
Hide resolved
mosche
added
the
auto-merge-without-approval
… component paths.
…clude production sources
|
Serverless test failures are unrelated, trying to re-run them. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Jul 14, 2025
…tic#130825) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190 Relates to ES-12210 Relates to ES-12242 (cherry picked from commit 3f0b14b) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Jul 14, 2025
…tic#130825) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190 Relates to ES-12210 Relates to ES-12242 (cherry picked from commit 3f0b14b) # Conflicts: # muted-tests.yml
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 14, 2025
…king * upstream/main: (33 commits) Allow both WithEntitlementsOnTestCode and EntitledTestPackages together (elastic#130826) Move streams status actions to cluster:monitor group (elastic#131015) Update JDK base image for OIDC fixture (elastic#131176) Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testLookupJoinAliases elastic#131166 Mute org.elasticsearch.index.engine.ThreadPoolMergeExecutorServiceDiskSpaceTests testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges elastic#131165 Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testNotLikeListKeyword elastic#131155 Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#131154 Check file entitlements on the Lucene FilterFileSystem in tests (elastic#130825) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {lookup-join.MvJoinKeyOnFromAfterStats ASYNC} elastic#131148 Move FrequencyCappedAction to common package (elastic#131060) Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQueryLocal elastic#121672 Remove nesting from multi allocation decision (elastic#130844) Disable async search rest tests in release builds (elastic#131132) Fix testStopQueryLocal (elastic#131130) Fixes based on resharding disruption tests (elastic#130870) Remove inactive logger (elastic#131121) Add wait for remote start for the test (elastic#131124) Add existing shards allocator settings to failure store allowed list. (elastic#131056) Don't allow field caps to use semantic queries as index filters (elastic#131111) issue should be already fixed by elastic#121466 (elastic#130860) ...
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 14, 2025
) (#131184) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes #127686 Fixes #127193 Fixes #127192 Fixes #127190 Relates to ES-12210 Relates to ES-12242 (cherry picked from commit 3f0b14b) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 14, 2025
) (#131185) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes #127686 Fixes #127193 Fixes #127192 Fixes #127190 Relates to ES-12210 Relates to ES-12242 (cherry picked from commit 3f0b14b) # Conflicts: # muted-tests.yml
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…tic#130825) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190 Relates to ES-12210 Relates to ES-12242
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…tic#130825) So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem. This makes sure we properly check for that file system in tests. Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190 Relates to ES-12210 Relates to ES-12242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem.
This makes sure we properly check for that file system in tests.
Fixes #127686
Fixes #127193
Fixes #127192
Fixes #127190
Relates to ES-12210
Relates to ES-12242