Skip to content

Conversation

not-napoleon
Copy link
Member

This pulls #130845 into the serverless fix branch for patch deployment.

… instead of interacting with doc values api directly.

This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
@not-napoleon not-napoleon added >bug :StorageEngine/Mapping The storage related side of mappings v9.2.0 labels Jul 8, 2025
@elasticsearchmachine elasticsearchmachine added serverless-linked Added by automation, don't add manually Team:StorageEngine labels Jul 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@not-napoleon not-napoleon enabled auto-merge (squash) July 8, 2025 20:52
@not-napoleon not-napoleon merged commit 256acca into elastic:patch/serverless-fix Jul 8, 2025
35 checks passed
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jul 9, 2025
… instead of interacting with doc values api directly. (elastic#130854)

This pulls elastic#130845 into the serverless fix branch for patch deployment.  Original description:

Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly.

This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.

Co-authored-by: Martijn van Groningen <[email protected]>
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jul 9, 2025
… instead of interacting with doc values api directly. (elastic#130854)

This pulls elastic#130845 into the serverless fix branch for patch deployment.  Original description:

Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly.

This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.

Co-authored-by: Martijn van Groningen <[email protected]>
martijnvg added a commit that referenced this pull request Jul 9, 2025
… instead of interacting with doc values api directly. (#130895)

Backporting #130854 to 9.1 branch.

This pulls #130845 into the serverless fix branch for patch deployment.  Original description:

Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly.

This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.

Co-authored-by: Mark Tozzi <[email protected]>
martijnvg added a commit that referenced this pull request Jul 9, 2025
… instead of interacting with doc values api directly. (#130896)

Backporting #130854 to 8.19 branch.

This pulls #130845 into the serverless fix branch for patch deployment.  Original description:

Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly.

This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.

Co-authored-by: Mark Tozzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug serverless-linked Added by automation, don't add manually :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants