Remove deprecated Metadata.Builder#putProjectCustom
#130862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the deprecated method with appropriate substitute.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
commented
Jul 8, 2025
| expectThrows(NullPointerException.class, () -> builder.putCustom(key, (Metadata.ClusterCustom) null)).getMessage(), | ||
| containsString(key) | ||
| ); | ||
| assertThat(expectThrows(NullPointerException.class, () -> builder.putProjectCustom(key, null)).getMessage(), containsString(key)); |
Contributor
Author
There was a problem hiding this comment.
This assertion is moved to ProjectMetadataTests in #130846, so I'm just removing it here as well to pass compilation.
ywangd
approved these changes
Jul 11, 2025
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
One comment that I'd appreciate to be addressed.
server/src/main/java/org/elasticsearch/cluster/metadata/Metadata.java
Outdated
Show resolved
Hide resolved
jdconrad
pushed a commit
to JVerwolf/elasticsearch
that referenced
this pull request
Jul 14, 2025
Replaces the deprecated method with appropriate substitute.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Replaces the deprecated method with appropriate substitute.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Replaces the deprecated method with appropriate substitute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated method with appropriate substitute.