Skip to content

Remove ClusterStateSerializationTests #130877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

Remove ClusterStateSerializationTests #130877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
427f0aa
Remove `ClusterStateSerializationTests`
nielsbauman Jul 8, 2025
a0d372e
Merge branch 'main' into fix-130872
nielsbauman Jul 15, 2025
136360e
Add new test
nielsbauman Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,6 @@ tests:
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: test {p0=mtermvectors/10_basic/Tests catching other exceptions per item}
issue: https://github.com/elastic/elasticsearch/issues/122414
- class: org.elasticsearch.cluster.ClusterStateSerializationTests
method: testSerializationPreMultiProject
issue: https://github.com/elastic/elasticsearch/issues/130872
- class: org.elasticsearch.search.SearchWithRejectionsIT
method: testOpenContextsAfterRejections
issue: https://github.com/elastic/elasticsearch/issues/130821
Expand Down
85 changes: 0 additions & 85 deletions server/src/test/java/org/elasticsearch/cluster/ClusterStateSerializationTests.java
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions server/src/test/java/org/elasticsearch/cluster/metadata/MetadataTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
package org.elasticsearch.cluster.metadata;

import org.elasticsearch.TransportVersion;
import org.elasticsearch.TransportVersions;
import org.elasticsearch.cluster.ClusterModule;
import org.elasticsearch.cluster.Diff;
import org.elasticsearch.cluster.coordination.CoordinationMetadata;
Expand Down Expand Up @@ -45,6 +46,7 @@
import org.elasticsearch.persistent.PersistentTasksService;
import org.elasticsearch.test.AbstractChunkedSerializingTestCase;
import org.elasticsearch.test.ESTestCase;
import org.elasticsearch.test.TransportVersionUtils;
import org.elasticsearch.test.index.IndexVersionUtils;
import org.elasticsearch.test.rest.ObjectPath;
import org.elasticsearch.threadpool.ThreadPool;
Expand Down Expand Up @@ -613,6 +615,17 @@ public void testMultiProjectSerialization() throws IOException {
}
}

public void testUnableToSerializeNonDefaultProjectBeforeMultiProject() {
final var projectId = randomUniqueProjectId();
Metadata metadata = Metadata.builder().put(ProjectMetadata.builder(projectId)).build();

try (BytesStreamOutput output = new BytesStreamOutput()) {
output.setTransportVersion(TransportVersionUtils.getPreviousVersion(TransportVersions.MULTI_PROJECT));
var e = assertThrows(UnsupportedOperationException.class, () -> metadata.writeTo(output));
assertEquals("There is 1 project, but it has id [" + projectId + "] rather than default", e.getMessage());
}
}

public void testGetNonExistingProjectThrows() {
final List<ProjectMetadata> projects = IntStream.range(0, between(1, 3))
.mapToObj(i -> randomProject(ProjectId.fromId("p_" + i), between(0, 5)))
Expand Down