Skip to content

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Jul 9, 2025

Fixing DataStreamDeprecationCheckerTests.testOldIndicesCheckWithOnlyNewIndices() fails if it attempts to create a data stream with 0 backing indices. This happens if both newOpenIndexCount and newClosedIndexCount are randomly 0, which happens less than 1 in 10,000 times.
Closes #130285

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles v9.2.0 v8.19.1 auto-backport Automatically create backport pull requests when merged labels Jul 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 9, 2025
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Keith!

@masseyke masseyke merged commit 818d31a into elastic:main Jul 9, 2025
33 checks passed
@masseyke masseyke deleted the fix/DataStreamDeprecationCheckerTests branch July 9, 2025 21:04
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jul 9, 2025
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jul 9, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19
9.0
8.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] DataStreamDeprecationCheckerTests testOldIndicesCheckWithOnlyNewIndices failing

3 participants