Fix data race with AbstractPageMappingToIteratorOperator #130963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
the
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Ouch. |
nik9000
approved these changes
Jul 9, 2025
|
Thanks Nik! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 10, 2025
) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via Relates elastic#130573 Closes elastic#130959 Closes elastic#130958 Closes elastic#130950 Closes elastic#130925 Closes elastic#130881 Closes elastic#130796
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jul 10, 2025
) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via Relates elastic#130573 Closes elastic#130959 Closes elastic#130958 Closes elastic#130950 Closes elastic#130925 Closes elastic#130881 Closes elastic#130796
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
…130972) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via Relates #130573 Closes #130959 Closes #130958 Closes #130950 Closes #130925 Closes #130881 Closes #130796
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 10, 2025
…130971) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via Relates #130573 Closes #130959 Closes #130958 Closes #130950 Closes #130925 Closes #130881 Closes #130796
This was referenced Jul 10, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via #allowPassingToDifferentDriver. Relates elastic#130573 Closes elastic#130959 Closes elastic#130958 Closes elastic#130950 Closes elastic#130925 Closes elastic#130881 Closes elastic#130796
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
) We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe. An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via #allowPassingToDifferentDriver. Relates elastic#130573 Closes elastic#130959 Closes elastic#130958 Closes elastic#130950 Closes elastic#130925 Closes elastic#130881 Closes elastic#130796
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 17, 2025
Fixed by elastic#131370 or elastic#130963. Closes elastic#130505 Closes elastic#130504 Closes elastic#130501 Closes elastic#131024
This was referenced Jul 17, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to release the blocks of the page in AbstractPageMappingToIteratorOperator immediately in single-iteration cases, instead of delaying to the next iteration. This is because the blocks of the page are now shared with the output page. The output page can be passed to a separate driver, which may run concurrently with this driver, leading to data races in AbstractNonThreadSafeRefCounted, which is not thread-safe.
An alternative would be to make RefCounted for Vectors/Blocks thread-safe when they are about to be shared with other drivers via #allowPassingToDifferentDriver.
Relates #130573
Closes #130959
Closes #130958
Closes #130950
Closes #130925
Closes #130881
Closes #130796