Skip to content

ES|QL: Infer score mode from collector #131006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

ES|QL: Infer score mode from collector #131006

merged 2 commits into from
Jul 10, 2025

Conversation

ioanatia
Copy link
Contributor

brings back the optimization from #125930

@ioanatia ioanatia added auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.19.0 v9.1.0 Team:Search - Relevance The Search organization Search Relevance team v9.2.0 labels Jul 10, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed Team:Search - Relevance The Search organization Search Relevance team labels Jul 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ioanatia ioanatia requested review from ChrisHegarty and jimczi July 10, 2025 12:21
jimczi
jimczi approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the collector to determine the score mode is the best approach, LGTM!

ChrisHegarty
ChrisHegarty approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioanatia ioanatia merged commit 3708770 into elastic:main Jul 10, 2025
35 checks passed
@ioanatia ioanatia mentioned this pull request Jul 10, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
✅ 9.1

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131006

ioanatia added a commit to ioanatia/elasticsearch that referenced this pull request Jul 10, 2025
@ioanatia
ES|QL: Infer score mode from collector (elastic#131006)
5f68b25
@ChrisHegarty
Copy link
Contributor

Not for now, but maybe as a follow up; does it make sense to add a score mode to the profile output of the LuceneOperator, so that it could be checked and asserted in an IT ?

@ioanatia
Copy link
Contributor Author

Not for now, but maybe as a follow up; does it make sense to add a score mode to the profile output of the LuceneOperator, so that it could be checked and asserted in an IT ?

yes it does - but it's not trivial at all.

@ioanatia ioanatia mentioned this pull request Jul 11, 2025
Merged
ioanatia added a commit to ioanatia/elasticsearch that referenced this pull request Jul 11, 2025
@ioanatia
ES|QL: Infer score mode from collector (elastic#131006)
72085cb
elasticsearchmachine pushed a commit that referenced this pull request Jul 11, 2025
@ioanatia
ES|QL: Infer score mode from collector (#131006) (#131023)
9e054f5
ioanatia added a commit that referenced this pull request Jul 11, 2025
@ioanatia
ES|QL: Infer score mode from collector (#131006) (#131083)
bf2063e
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@ioanatia @mridula-s109
ES|QL: Infer score mode from collector (elastic#131006)
44a1219
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@ioanatia @mridula-s109
ES|QL: Infer score mode from collector (elastic#131006)
0790f7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimczi jimczi jimczi approved these changes

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.1.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ioanatia @elasticsearchmachine @ChrisHegarty @jimczi