ESQL - Clean up non-parametrized tests #131049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
Jul 10, 2025
idegtiarenko
approved these changes
Jul 14, 2025
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
I'm backporting. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Jul 15, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
nik9000
added a commit
that referenced
this pull request
Jul 16, 2025
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTests ran 832 tests before this, and now runs 640 tests
StartsWithTests ran 208 before this, and now runs 160
InTests ran 168 before this, and now runs 28
So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.
Co-authored-by: Mark Tozzi <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Clean up non-parameterized tests in the wrong place (#131049) In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage. I cleaned up three classes: EndsWithTests ran 832 tests before this, and now runs 640 tests StartsWithTests ran 208 before this, and now runs 160 InTests ran 168 before this, and now runs 28 So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests. * Fixup --------- Co-authored-by: Mark Tozzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of other work I found a few places where we were creating non-parameterized tests from within the parameterized test drivers for a few ESQL functions. This causes those tests to be run for every parameter combination, even though the tests themselves do not change anything, resulting in a lot of extra test overhead for no additional coverage.
I cleaned up three classes:
EndsWithTestsran 832 tests before this, and now runs 640 testsStartsWithTestsran 208 before this, and now runs 160InTestsran 168 before this, and now runs 28So overall, that's 369 redundant test runs removed (including the fact that the 11 tests I moved still run once in their new classes), and further savings if we later expand those parameterized tests.