-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup #131103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dan-rubinstein
merged 4 commits into
elastic:main
from
dan-rubinstein:recursive-chunking-fixes
Jul 14, 2025
Merged
Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup #131103
dan-rubinstein
merged 4 commits into
elastic:main
from
dan-rubinstein:recursive-chunking-fixes
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to SeparatorGroup
Pinging @elastic/ml-core (Team:ML) |
Hi @dan-rubinstein, I've created a changelog YAML for you. |
davidkyle
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Jul 14, 2025
…to SeparatorGroup (elastic#131103) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Jul 14, 2025
…to SeparatorGroup (elastic#131103) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 14, 2025
…to SeparatorGroup (#131103) (#131228) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
dan-rubinstein
added a commit
that referenced
this pull request
Jul 14, 2025
…torSet to SeparatorGroup (#131103) (#131227) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup (#131103) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]> * Removing getFirst calls --------- Co-authored-by: Elastic Machine <[email protected]>
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…to SeparatorGroup (elastic#131103) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…to SeparatorGroup (elastic#131103) * Adding merging logic to recursive chunking and renaming SeparatorSet to SeparatorGroup * Update docs/changelog/131103.yaml * Delete docs/changelog/131103.yaml --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:ml
Machine learning
>non-issue
Team:ML
Meta label for the ML team
v8.19.0
v9.1.0
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes two fixes for the recursive chunking strategy: