Skip to content

[ML] Including max_tokens through the Service API for Anthropic #131113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

[ML] Including max_tokens through the Service API for Anthropic #131113

merged 2 commits into from
Jul 14, 2025

Conversation

jonathan-buttner
Copy link
Contributor

This PR fixes a bug where the anthropic service wasn't exposing the required field max_tokens. This caused the UI to fail to create the service because it wasn't sending the field.

Example response from the get service API now

    {
        "service": "anthropic",
        "name": "Anthropic",
        "task_types": [
            "completion"
        ],
        "configurations": {
            "max_tokens": {
                "description": "The maximum number of tokens to generate before stopping.",
                "label": "Max Tokens",
                "required": true,
                "sensitive": false,
                "updatable": false,
                "type": "int",
                "supported_task_types": [
                    "completion"
                ]
            },

@jonathan-buttner jonathan-buttner added >bug :ml Machine learning Team:ML Meta label for the ML team auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 11, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @jonathan-buttner, I've created a changelog YAML for you.

davidkyle
davidkyle approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner jonathan-buttner marked this pull request as ready for review July 14, 2025 13:38
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jonathan-buttner jonathan-buttner merged commit 2478b5c into elastic:main Jul 14, 2025
33 checks passed
@jonathan-buttner jonathan-buttner deleted the ml-max-tokens-anthropic branch July 14, 2025 14:24
@jonathan-buttner jonathan-buttner mentioned this pull request Jul 14, 2025
Merged
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (elas…
29da882 
…tic#131113)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
This was referenced Jul 14, 2025
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 8.19
✅ 9.0
✅ 8.18

jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (elas…
dd9d481 
…tic#131113)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (elas…
47a94c6 
…tic#131113)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (#131113
c55c350 
) (#131215)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (#131113
063f9db 
) (#131218)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (#131113
6193eef 
) (#131219)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@jonathan-buttner
[ML] Including max_tokens through the Service API for Anthropic (#131113
49138c1 
) (#131216)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@jonathan-buttner @mridula-s109
[ML] Including max_tokens through the Service API for Anthropic (elas…
e8e256f 
…tic#131113)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@jonathan-buttner @mridula-s109
[ML] Including max_tokens through the Service API for Anthropic (elas…
3e34702 
…tic#131113)

* Adding max_tokens to get services API

* Update docs/changelog/131113.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonathan-buttner @elasticsearchmachine @davidkyle