POC: Cross-Project Search

.buildkite/pipelines/periodic-fwc.template.yml

@@ -1,5 +1,5 @@
 steps:
-  - label: "{{matrix.FWC_VERSION}} / fwc"
+  - label: "{{matrix.FWC_VERSION}}" / fwc
     command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v$$FWC_VERSION#fwcTest -Dtests.bwc.snapshot=false
     timeout_in_minutes: 300
     agents:

.buildkite/pipelines/periodic-fwc.yml

@@ -1,6 +1,6 @@
 # This file is auto-generated. See .buildkite/pipelines/periodic-fwc.template.yml
 steps:
-  - label: "{{matrix.FWC_VERSION}} / fwc"
+  - label: "{{matrix.FWC_VERSION}}" / fwc
     command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v$$FWC_VERSION#fwcTest -Dtests.bwc.snapshot=false
     timeout_in_minutes: 300
     agents:

.buildkite/pipelines/pull-request/pr-upgrade.yml

@@ -2,5 +2,5 @@ steps:
   - label: pr-upgrade
     command: ".buildkite/scripts/run-pr-upgrade-tests.sh"
     agents:
-      image: "docker.elastic.co/ci-agent-images/eck-region/buildkite-agent:1.15"
+      image: "docker.elastic.co/ci-agent-images/eck-region/buildkite-agent:1.5"
       memory: "4G"

.buildkite/pull-requests.json

@@ -16,25 +16,6 @@
       "cancel_intermediate_builds": true,
       "cancel_intermediate_builds_on_comment": false
     },
-    {
-      "enabled": true,
-      "target_branch": "main",
-      "pipeline_slug": "elasticsearch-pull-request-transport-versions",
-      "allow_org_users": true,
-      "allowed_repo_permissions": [
-        "admin",
-        "write"
-      ],
-      "allowed_list": ["elastic-renovate-prod[bot]"],
-      "set_commit_status": false,
-      "build_on_commit": true,
-      "build_on_comment": true,
-      "trigger_comment_regex": "(run\\W+elasticsearch-ci.+)|(^\\s*((buildkite|@elastic(search)?machine)\\s*)?test\\s+this(\\s+please)?)",
-      "retrigger_label_regex": "v[0-9]+\\.[0-9]+\\.[0-9]+",
-      "cancel_intermediate_builds": true,
-      "cancel_intermediate_builds_on_comment": false,
-      "skip_duplicate_builds": true
-    },
     {
       "enabled": true,
       "pipeline_slug": "elasticsearch-pull-request-performance-benchmark",

TESTING.asciidoc

@@ -681,15 +681,12 @@ There are multiple base classes for tests:
   directly by unit tests.
 * **`ESSingleNodeTestCase`**: This test case sets up a cluster that has a
   single node.
-* **`ESIntegTestCase`**: An internal integration test that starts nodes within the same JVM as the test.
-    These allow you to test functionality that is not exposed via the REST API, or for verifying a certain internal state.
-    Additionally, you can easily simulate tricky distributed setups that are difficult to do in REST tests.
-    If you only need to start one node, use `ESSingleNodeTestCase` instead, which is a much lighter test setup.
-* **`ESRestTestCase`**: An integration test that interacts with an external
-  cluster via the REST API. This is used for Java based REST tests. This should
-  be the first choice for writing integration tests as these tests run in a much more
-  realistic setup.
-* **`ESClientYamlSuiteTestCase` **: A subclass of `ESRestTestCase` used to run YAML based REST tests.
+* **`ESIntegTestCase`**: An integration test case that creates a cluster that
+  might have multiple nodes.
+* **`ESRestTestCase`**: An integration tests that interacts with an external
+  cluster via the REST API. This is used for Java based REST tests.
+* **`ESClientYamlSuiteTestCase` **: A subclass of `ESRestTestCase` used to run
+  YAML based REST tests.
 
 === Good practices
 

benchmarks/src/main/java/org/elasticsearch/benchmark/vector/OptimizedScalarQuantizerBenchmark.java

@@ -42,7 +42,6 @@ public class OptimizedScalarQuantizerBenchmark {
     int dims;
 
     float[] vector;
-    float[] scratch;
     float[] centroid;
     int[] destination;
 
@@ -58,7 +57,6 @@ public void init() {
         destination = new int[dims];
         vector = new float[dims];
         centroid = new float[dims];
-        scratch = new float[dims];
         for (int i = 0; i < dims; ++i) {
             vector[i] = random.nextFloat();
             centroid[i] = random.nextFloat();
@@ -67,14 +65,14 @@ public void init() {
 
     @Benchmark
     public int[] scalar() {
-        osq.scalarQuantize(vector, scratch, destination, bits, centroid);
+        osq.scalarQuantize(vector, destination, bits, centroid);
         return destination;
     }
 
     @Benchmark
     @Fork(jvmArgsPrepend = { "--add-modules=jdk.incubator.vector" })
     public int[] vector() {
-        osq.scalarQuantize(vector, scratch, destination, bits, centroid);
+        osq.scalarQuantize(vector, destination, bits, centroid);
         return destination;
     }
 }

build-conventions/settings.gradle

@@ -8,7 +8,7 @@
  */
 
 plugins {
-  id "com.gradle.develocity" version "4.1.1"
+  id "com.gradle.develocity" version "4.0.1"
 }
 
 rootProject.name = 'build-conventions'

build-conventions/src/main/java/org/elasticsearch/gradle/internal/conventions/VersionPropertiesBuildService.java

@@ -22,7 +22,7 @@
 import java.util.Properties;
 import javax.inject.Inject;
 
-public abstract class VersionPropertiesBuildService implements BuildService<VersionPropertiesBuildService.Params>, AutoCloseable {
+abstract class VersionPropertiesBuildService implements BuildService<VersionPropertiesBuildService.Params>, AutoCloseable {
 
     private final Properties properties;
 

build-tools-internal/settings.gradle

@@ -9,7 +9,7 @@ pluginManagement {
 }
 
 plugins {
-  id "com.gradle.develocity" version "4.1.1"
+  id "com.gradle.develocity" version "4.0.1"
 }
 
 dependencyResolutionManagement {

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/ElasticsearchTestBasePluginFuncTest.groovy

@@ -108,65 +108,4 @@ class ElasticsearchTestBasePluginFuncTest extends AbstractGradleFuncTest {
         then:
         result.task(':test').outcome == TaskOutcome.UP_TO_DATE
     }
-
-    def "uses new test seed for every invocation"() {
-        given:
-        file("src/test/java/acme/SomeTests.java").text = """
-
-        public class SomeTests {
-            @org.junit.Test
-            public void printTestSeed() {
-                System.out.println("TESTSEED=[" + System.getProperty("tests.seed") + "]");
-            }
-        }
-
-        """
-        buildFile.text = """
-            plugins {
-             id 'java'
-             id 'elasticsearch.test-base'
-            }
-
-            tasks.named('test').configure {
-                testLogging {
-                    showStandardStreams = true
-                }
-            }
-
-            tasks.register('test2', Test) {
-                classpath = sourceSets.test.runtimeClasspath
-                testClassesDirs = sourceSets.test.output.classesDirs
-                testLogging {
-                    showStandardStreams = true
-                }
-            }
-
-            repositories {
-                mavenCentral()
-            }
-
-            dependencies {
-                testImplementation 'junit:junit:4.12'
-            }
-
-        """
-
-        when:
-        def result1 = gradleRunner("cleanTest", "cleanTest2", "test", "test2").build()
-        def result2 = gradleRunner("cleanTest", "cleanTest2", "test", "test2").build()
-
-        then:
-        def seeds1 = result1.output.findAll(/(?m)TESTSEED=\[([^\]]+)\]/) { it[1] }
-        def seeds2 = result2.output.findAll(/(?m)TESTSEED=\[([^\]]+)\]/) { it[1] }
-
-        seeds1.unique().size() == 1
-        seeds2.unique().size() == 1
-
-        verifyAll {
-            seeds1[0] != null
-            seeds2[0] != null
-            seeds1[0] != seeds2[0]
-        }
-        result2.output.contains("Configuration cache entry reused.")
-    }
 }