ES|QL: fix MultiClustersIT.testNotLikeListKeyword #131199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Jul 14, 2025
| TestEntitlementBootstrap.setActive(false == withoutEntitlements); | ||
| TestEntitlementBootstrap.setTriviallyAllowingTestCode(false == withEntitlementsOnTestCode); | ||
| if (entitledPackages != null) { | ||
| assert withEntitlementsOnTestCode == false : "Cannot use @WithEntitlementsOnTestCode together with @EntitledTestPackages"; |
There was a problem hiding this comment.
No... probably a fat finger, let me fix it
There was a problem hiding this comment.
I think GitHub is not having a good day... I didn't change it, this PR did, so that change is already in main.
Updating the PR branch fixed the "problem"
idegtiarenko
approved these changes
Jul 14, 2025
|
@luigidellaquila Thank you for addressing this and sorry I missed this in my PR. I will backport this in 9.1 and 8.19 as the fix is needed there too. |
julian-elastic
pushed a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jul 14, 2025
(cherry picked from commit d154230) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
julian-elastic
pushed a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jul 14, 2025
(cherry picked from commit d154230) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
julian-elastic
added a commit
that referenced
this pull request
Jul 14, 2025
(cherry picked from commit d154230) # Conflicts: # muted-tests.yml Co-authored-by: Luigi Dell'Aquila <[email protected]>
julian-elastic
added a commit
that referenced
this pull request
Jul 14, 2025
(cherry picked from commit d154230) # Conflicts: # muted-tests.yml Co-authored-by: Luigi Dell'Aquila <[email protected]>
|
Thanks @julian-elastic! |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make testNotLikeListKeyword more deterministic: in some cases, it returns no values for the remote or for the local cluster, that is just a consequence of the randomization.
Fixes: #131155