Skip to content

Conversation

slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Jul 14, 2025

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867

 - bump docker startup timeout to account for slow security autoconfiguration

Resolves elastic#129808
@slobodanadamovic slobodanadamovic self-assigned this Jul 14, 2025
@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label Team:Security Meta label for security team test-release Trigger CI checks against release build labels Jul 14, 2025
@slobodanadamovic slobodanadamovic changed the title Unmute docker tests to get some fresh failures Unmute docker tests to get some fresh logs Jul 14, 2025
@slobodanadamovic slobodanadamovic removed the test-release Trigger CI checks against release build label Jul 14, 2025
@slobodanadamovic slobodanadamovic changed the title Unmute docker tests to get some fresh logs Unmute docker tests, add more logging and increase startup timeout Jul 15, 2025
while (started == false && timeElapsed < waitTime) {
if (System.currentTimeMillis() - lastRequest > requestInterval) {
if (caCert == null) {
caCert = getCaCert(installation);
Copy link
Contributor Author

@slobodanadamovic slobodanadamovic Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of slow auto-configuration, the HTTP CA certificate may not have been configured when waitForElasticsearch method is called. This would result in received plaintext http traffic on an https channel, closing connection Netty4HttpChannel and test failure after 3 minutes. See this comment for more details: #123437 (comment)

@slobodanadamovic slobodanadamovic added auto-backport Automatically create backport pull requests when merged v9.1.1 v8.19.1 v9.0.5 v8.18.5 labels Jul 15, 2025
failed = true;
if (installation != null && installation.distribution.isDocker()) {
logger.warn("Test {} failed. Printing logs for failed test...", description.getMethodName());
FileUtils.logAllLogs(installation.logs, logger);
Copy link
Contributor Author

@slobodanadamovic slobodanadamovic Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the uncaught docker failures did not include any cluster logs, which makes it super hard to troubleshoot.

@slobodanadamovic slobodanadamovic requested review from a team July 15, 2025 11:09
@slobodanadamovic slobodanadamovic marked this pull request as ready for review July 15, 2025 11:09
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic slobodanadamovic merged commit 4806156 into elastic:main Jul 15, 2025
39 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts
8.18 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131203

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Jul 15, 2025
…lastic#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves elastic#129808
Resolves elastic#123437
Resolves elastic#120911
Resolves elastic#120914
Resolves elastic#120910
Resolves elastic#120918
Resolves elastic#120925
Resolves elastic#124990
Resolves elastic#116636
Resolves elastic#125680
Resolves elastic#116147
Resolves elastic#126232
Resolves elastic#126145
Resolves elastic#116866
Resolves elastic#126936
Resolves elastic#127081
Resolves elastic#127158
Resolves elastic#127138
Resolves elastic#128018
Resolves elastic#128031
Resolves elastic#128110
Resolves elastic#128006
Resolves elastic#128174
Resolves elastic#128144
Resolves elastic#128165
Resolves elastic#128075
Resolves elastic#128117
Resolves elastic#128121
Resolves elastic#128115
Resolves elastic#128230
Resolves elastic#128120
Resolves elastic#128996
Resolves elastic#128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Jul 15, 2025
…lastic#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves elastic#129808
Resolves elastic#123437
Resolves elastic#120911
Resolves elastic#120914
Resolves elastic#120910
Resolves elastic#120918
Resolves elastic#120925
Resolves elastic#124990
Resolves elastic#116636
Resolves elastic#125680
Resolves elastic#116147
Resolves elastic#126232
Resolves elastic#126145
Resolves elastic#116866
Resolves elastic#126936
Resolves elastic#127081
Resolves elastic#127158
Resolves elastic#127138
Resolves elastic#128018
Resolves elastic#128031
Resolves elastic#128110
Resolves elastic#128006
Resolves elastic#128174
Resolves elastic#128144
Resolves elastic#128165
Resolves elastic#128075
Resolves elastic#128117
Resolves elastic#128121
Resolves elastic#128115
Resolves elastic#128230
Resolves elastic#128120
Resolves elastic#128996
Resolves elastic#128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml
@slobodanadamovic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1
9.0
8.19
8.18

Questions ?

Please refer to the Backport tool documentation

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Jul 15, 2025
…lastic#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves elastic#129808
Resolves elastic#123437
Resolves elastic#120911
Resolves elastic#120914
Resolves elastic#120910
Resolves elastic#120918
Resolves elastic#120925
Resolves elastic#124990
Resolves elastic#116636
Resolves elastic#125680
Resolves elastic#116147
Resolves elastic#126232
Resolves elastic#126145
Resolves elastic#116866
Resolves elastic#126936
Resolves elastic#127081
Resolves elastic#127158
Resolves elastic#127138
Resolves elastic#128018
Resolves elastic#128031
Resolves elastic#128110
Resolves elastic#128006
Resolves elastic#128174
Resolves elastic#128144
Resolves elastic#128165
Resolves elastic#128075
Resolves elastic#128117
Resolves elastic#128121
Resolves elastic#128115
Resolves elastic#128230
Resolves elastic#128120
Resolves elastic#128996
Resolves elastic#128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
…out (#131203) (#131293)

* Unmute docker tests, add more logging and increase startup timeout (#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml

* call dumpDebug
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
…eout (#131203) (#131294)

* Unmute docker tests, add more logging and increase startup timeout (#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml

* call dumpDebug
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
…eout (#131203) (#131295)

* Unmute docker tests, add more logging and increase startup timeout (#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml

* call dumpDebug
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Jul 15, 2025
This test timed out due to slow security auto-configuration.
The elastic#131203 increased timeout from 30s to 45s, which should hopefully
be enough.

Resolves elastic#131107
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
…out (#131203) (#131292)

* Unmute docker tests, add more logging and increase startup timeout (#131203)

Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.

Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867

(cherry picked from commit 4806156)

# Conflicts:
#	muted-tests.yml

* call dump debug logs
@brianseeders
Copy link
Contributor

@slobodanadamovic Our periodic packaging jobs have tons of failures now after unmuting all of these tests... See here for an example: https://buildkite.com/elastic/elasticsearch-periodic-packaging/builds/9057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment