Skip to content

Exclude .triggered-watches from indices cleanup in REST tests #131235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Exclude .triggered-watches from indices cleanup in REST tests #131235

merged 1 commit into from
Jul 14, 2025

Conversation

nielsbauman
Copy link
Contributor

Some tests were seeing an unexpected warning header from wiping all indices in the test cleanup, caused by the .triggered-watches data stream being present. We exclude the backing indices of this data stream from the indices wipe to avoid the warning header. The presence of this data stream shouldn't intefere with tests, and any tests that do interact with that data stream should assert/control its state by themselves to ensure consistency.

Fixes #129682

@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests
5517a1c 
Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
@nielsbauman nielsbauman requested a review from masseyke July 14, 2025 18:57
@nielsbauman nielsbauman added >test Issues or PRs that are addressing/adding tests :Data Management/Watcher auto-backport Automatically create backport pull requests when merged v9.1.1 v8.19.1 v9.0.5 v8.17.10 v8.18.5 labels Jul 14, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v9.2.0 labels Jul 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@nielsbauman nielsbauman mentioned this pull request Jul 14, 2025
Closed
dakrone
dakrone approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielsbauman nielsbauman merged commit 2b715f5 into elastic:main Jul 14, 2025
33 checks passed
@nielsbauman nielsbauman deleted the fix-129682 branch July 14, 2025 21:17
@nielsbauman nielsbauman mentioned this pull request Jul 14, 2025
Merged
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (elas…
fe866b0 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
This was referenced Jul 14, 2025
Merged
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 8.19
✅ 9.0
✅ 8.17
✅ 8.18

nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (elas…
15d325b 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (elas…
fff7423 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (elas…
77fc11a 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (#131235
5040e9c 
) (#131242)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes #129682
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (#131235
250a3ec 
) (#131243)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes #129682
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (#131235
8a077d1 
) (#131241)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes #129682
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (#131235
08083cf 
) (#131245)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes #129682
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@nielsbauman
Exclude .triggered-watches from indices cleanup in REST tests (#131235
bce7ac2 
) (#131244)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes #129682
jdconrad pushed a commit to JVerwolf/elasticsearch that referenced this pull request Jul 14, 2025
@nielsbauman @jdconrad
Exclude .triggered-watches from indices cleanup in REST tests (elas…
49540db 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@nielsbauman @mridula-s109
Exclude .triggered-watches from indices cleanup in REST tests (elas…
2233f58 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@nielsbauman @mridula-s109
Exclude .triggered-watches from indices cleanup in REST tests (elas…
5e12972 
…tic#131235)

Some tests were seeing an unexpected warning header from wiping all
indices in the test cleanup, caused by the `.triggered-watches` data
stream being present. We exclude the backing indices of this data stream
from the indices wipe to avoid the warning header. The presence of this
data stream shouldn't intefere with tests, and any tests that do
interact with that data stream should assert/control its state by
themselves to ensure consistency.

Fixes elastic#129682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

@masseyke masseyke Awaiting requested review from masseyke

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Watcher Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.17.10 v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] DocsClientYamlTestSuiteIT test {yaml=reference/rest-api/watcher/put-watch/line_126} failing

3 participants

@nielsbauman @elasticsearchmachine @dakrone