Skip to content

Conversation

@slobodanadamovic
Copy link
Contributor

The number of plugin archives changed and triggered the assertion.

Changing the assertion to check for analysis-icu plugin archive
instead of asserting on number of archives. This will always fail
when new plugin is added (like microsoft-graph-authz).

Resolves #116866

The number of plugin archives changed and triggered the assertion.

Changing the assertion to check for `analysis-icu` plugin archive
instead of asserting on number of archives. This will always fail when
new plugin is added (like microsoft-graph-authz).

Resolves elastic#116866
@slobodanadamovic slobodanadamovic requested a review from a team July 16, 2025 08:53
@slobodanadamovic slobodanadamovic self-assigned this Jul 16, 2025
@slobodanadamovic slobodanadamovic added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v9.2.0 v9.1.1 v8.19.1 auto-backport Automatically create backport pull requests when merged labels Jul 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@slobodanadamovic slobodanadamovic added the >test Issues or PRs that are addressing/adding tests label Jul 16, 2025
Copy link
Contributor

@jozala jozala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. LGTM.

@slobodanadamovic slobodanadamovic added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 24, 2025
jozala added a commit to breskeby/elasticsearch that referenced this pull request Jul 28, 2025
as in elastic#131353

Changing the assertion to check for analysis-icu plugin archive
instead of asserting on number of archives. This will always fail
when new plugin is added (like microsoft-graph-authz).
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
* Standardize on docker image arch classifier (#130643)

* The number of plugin archives changed and triggered the assertion
as in #131353

Changing the assertion to check for analysis-icu plugin archive
instead of asserting on number of archives. This will always fail
when new plugin is added (like microsoft-graph-authz).

---------

Co-authored-by: Mariusz Józala <[email protected]>
Co-authored-by: Mariusz Jozala <[email protected]>
@elasticsearchmachine elasticsearchmachine merged commit c1d7e79 into elastic:main Jul 30, 2025
34 checks passed
@slobodanadamovic slobodanadamovic deleted the fix-test022InstallPluginsFromLocalArchive branch July 30, 2025 13:14
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] DockerTests test022InstallPluginsFromLocalArchive failing

3 participants