[DiskBBQ] Remove posting lists offsets from meta file #131379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Jul 16, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Putting by the raw centroid is good. We only read the raw centroid when we quantize for scoring the posting list, and that is also when we need the offset.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently writing to meta the list of offsets for the posting lists. This means that we need to hold that array on heap when reading a segment. This arrays can get pretty big for a high number of centroids, therefore this commit proposes to remove that data from the meta file, instead we are adding the offsets just after the centroids, together with the raw centroid.
There is not noticeable effect in performance