Skip to content

Conversation

@leemthompo
Copy link
Contributor

^^

@leemthompo leemthompo requested a review from shainaraskas July 16, 2025 18:00
@leemthompo leemthompo self-assigned this Jul 16, 2025
@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v9.0.0 v9.1.0 labels Jul 16, 2025
@leemthompo leemthompo enabled auto-merge (squash) July 16, 2025 18:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

🔍 Preview links for changed docs

@shainaraskas
Copy link
Contributor

having a dedicated page for this feels a little strange to me (we could rely on the note here) but I expect you have your reasons so 🤐

however I think perhaps the move here is removed as you had it before, because this was a lifecycle state change, not a permanent state

@leemthompo
Copy link
Contributor Author

leemthompo commented Jul 17, 2025

@shainaraskas stuff has evolved since the migration, here's where my skull was at with this PR:

  • Sec/Obs are reviving the Managed connectors only for their UIs in 9.1.0, so removed probably doesn't make sense as the page will be updated again to not be a stub and will contain 9.1 info
  • I actually opened this because the build was complaining that removed isn't valid lifecycle status anymore 🤷

@shainaraskas
Copy link
Contributor

Sec/Obs are reviving the Managed connectors only for their UIs in 9.1.0, so removed probably doesn't make sense as the page will be updated again to not be a stub and will contain 9.1 info

will the badge be removed at that point?

I actually opened this because the build was complaining that removed isn't valid lifecycle status anymore 🤷

🤦 ... that should not be happening
image
https://elastic.github.io/docs-builder/syntax/applies/#lifecycle

it's a bug

@leemthompo
Copy link
Contributor Author

leemthompo commented Jul 17, 2025

Well here's the thing— pick your poison I guess:

  • ess: removed 9.0, preview 9.1
  • ess: deprecated 9.0, preview 9.1
  • ess: unavailable 9.0, preview 9.1

@shainaraskas
Copy link
Contributor

how do you feel about just preview 9.1? like pretend it's a new feature almost

if you want a specific 9.0 callout, I selected the least confusing to readers of the 3 although it's less than perfectly accurate

@shainaraskas
Copy link
Contributor

leaving a note for the record about not using stack versions in an ess tag but instead pairing tags when needed and explaining context/compatibility in prose

Co-authored-by: shainaraskas <[email protected]>
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope to never see this pr again lol

@leemthompo leemthompo merged commit 079355a into main Jul 23, 2025
11 checks passed
@leemthompo leemthompo deleted the leemthompo-patch-6 branch July 23, 2025 16:50
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131384

@leemthompo
Copy link
Contributor Author

@shainaraskas remember this PR? 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes Team:Docs Meta label for docs team v9.0.0 v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants