[DiskBBQ] Write the raw centroid on the posting list file instead of the centroids file #131421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the centroids file
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
# Conflicts: # server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsWriter.java
benwtrent
approved these changes
Jul 17, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
This makes things much simpler!
server/src/main/java/org/elasticsearch/index/codec/vectors/DefaultIVFVectorsReader.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently storing the raw centroid on the centroids file but this is only needed to quantize the vector query when visiting the posting lists. I think this data can be added at the beginning of the posting list instead so we keep our centroid file small.