Skip to content

Add optimized path for single segment in TS source #131502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnhatn merged 1 commit into from
Jul 18, 2025
Merged

Add optimized path for single segment in TS source #131502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 46 additions & 10 deletions ...esql/compute/src/main/java/org/elasticsearch/compute/lucene/TimeSeriesSourceOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,20 @@ void readDocsForNextPage() throws IOException {
for (LeafIterator leaf : oneTsidQueue) {
leaf.reinitializeIfNeeded(executingThread);
}
do {
PriorityQueue<LeafIterator> sub = subQueueForNextTsid();
if (sub.size() == 0) {
break;
}
tsHashesBuilder.appendNewTsid(sub.top().timeSeriesHash);
if (readValuesForOneTsid(sub)) {
break;
}
} while (mainQueue.size() > 0);
if (mainQueue.size() + oneTsidQueue.size() == 1) {
readValuesFromSingleRemainingLeaf();
} else {
do {
PriorityQueue<LeafIterator> sub = subQueueForNextTsid();
if (sub.size() == 0) {
break;
}
tsHashesBuilder.appendNewTsid(sub.top().timeSeriesHash);
if (readValuesForOneTsid(sub)) {
break;
}
} while (mainQueue.size() > 0);
}
}

private boolean readValuesForOneTsid(PriorityQueue<LeafIterator> sub) throws IOException {
Expand Down Expand Up @@ -236,6 +240,38 @@ private PriorityQueue<LeafIterator> subQueueForNextTsid() {
return oneTsidQueue;
}

private void readValuesFromSingleRemainingLeaf() throws IOException {
if (oneTsidQueue.size() == 0) {
oneTsidQueue.add(getMainQueue().pop());
tsidsLoaded++;
}
final LeafIterator sub = oneTsidQueue.top();
int lastTsid = -1;
do {
currentPagePos++;
remainingDocs--;
docCollector.collect(sub.segmentOrd, sub.docID);
if (lastTsid != sub.lastTsidOrd) {
tsHashesBuilder.appendNewTsid(sub.timeSeriesHash);
lastTsid = sub.lastTsidOrd;
}
tsHashesBuilder.appendOrdinal();
timestampsBuilder.appendLong(sub.timestamp);
if (sub.nextDoc() == false) {
if (sub.docID == DocIdSetIterator.NO_MORE_DOCS) {
oneTsidQueue.clear();
return;
} else {
++tsidsLoaded;
}
}
} while (remainingDocs > 0 && currentPagePos < maxPageSize);
}

private PriorityQueue<LeafIterator> getMainQueue() {
return mainQueue;
}

boolean completed() {
return mainQueue.size() == 0 && oneTsidQueue.size() == 0;
}
Expand Down