-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix semantic highlighting bug on flat quantized fields #131525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix semantic highlighting bug on flat quantized fields #131525
Conversation
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Hi @kderusso, I've created a changelog YAML for you. |
...nce/src/yamlRestTest/resources/rest-api-spec/test/inference/90_semantic_text_highlighter.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice clean fix and tests!
Can we also backport to 8.18 & 9.0? |
@Mikep86 there's no point to backporting to 8.18/9.0, because it's impossible to create a flat quantized |
💔 Backport failed
You can use sqren/backport to manually backport by running |
* Fix semantic highlighting bug on flat quantized fields * Update docs/changelog/131525.yaml (cherry picked from commit 90699d3) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceFeatures.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Fix semantic highlighting bug on flat quantized fields * Update docs/changelog/131525.yaml (cherry picked from commit 90699d3) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/InferenceFeatures.java
Resolves #131443
Resolves a bug where
semantic_text
fields configuringindex_options
to flat quantization types were not returning results from thesemantic
highlighter.Example to reproduce issue: