Tests: Add logging to FieldSortIT #131558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>test
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
benchaplin
approved these changes
Jul 19, 2025
| protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) { | ||
| return Settings.builder() | ||
| .put(super.nodeSettings(nodeOrdinal, otherSettings)) | ||
| .put(NetworkModule.HTTP_TYPE_KEY, Netty4Plugin.NETTY_HTTP_TRANSPORT_NAME) |
There was a problem hiding this comment.
Good point, I honestly just copied this from another test that used the RestClient because otherwise I got errors using the "/_cat/shards" call I need for the logging later. I removed the settings now but left the "addMockHttpTransport" override in the test, that seems to works as well.
In order to better understand the infrequent failures in elastic#129445 and in the hope to reproduce the issue better, this PR adds logging around which shards and nodes documents end up in FieldSortIT#testSortMixedFieldTypes and increases the log level for this test suite in the o.e.search packages to TRACE and in some action.search packages to DEBUG to better understand where exceptions are thrown and to better trace how resources are released after that. Relates to elastic#129445
cbuescher
force-pushed
the
add-logging-129445
branch
from
de97c30 to
cd1dd08
Compare
cbuescher
added
the
auto-backport
This was referenced Jul 21, 2025
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 21, 2025
In order to better understand the infrequent failures in elastic#129445 and in the hope to reproduce the issue better, this PR adds logging around which shards and nodes documents end up in FieldSortIT#testSortMixedFieldTypes and increases the log level for this test suite in the o.e.search packages to TRACE and in some action.search packages to DEBUG to better understand where exceptions are thrown and to better trace how resources are released after that. Relates to elastic#129445
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 21, 2025
In order to better understand the infrequent failures in elastic#129445 and in the hope to reproduce the issue better, this PR adds logging around which shards and nodes documents end up in FieldSortIT#testSortMixedFieldTypes and increases the log level for this test suite in the o.e.search packages to TRACE and in some action.search packages to DEBUG to better understand where exceptions are thrown and to better trace how resources are released after that. Relates to elastic#129445
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
In order to better understand the infrequent failures in #129445 and in the hope to reproduce the issue better, this PR adds logging around which shards and nodes documents end up in FieldSortIT#testSortMixedFieldTypes and increases the log level for this test suite in the o.e.search packages to TRACE and in some action.search packages to DEBUG to better understand where exceptions are thrown and to better trace how resources are released after that. Relates to #129445
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
In order to better understand the infrequent failures in #129445 and in the hope to reproduce the issue better, this PR adds logging around which shards and nodes documents end up in FieldSortIT#testSortMixedFieldTypes and increases the log level for this test suite in the o.e.search packages to TRACE and in some action.search packages to DEBUG to better understand where exceptions are thrown and to better trace how resources are released after that. Relates to #129445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better understand the failures in #129445, this PR temporarily adds logging around where the
sort documents in FieldSortIT#testSortMixedFieldTypes are indexed and increases the log level for the
test suite in the o.e.search package to TRACE and in two o.e.action.search classes to DEBUG in order
to better understand where exceptions are thrown and to better trace how resources are released after that.
Relates to #129445