-
Notifications
You must be signed in to change notification settings - Fork 25.6k
TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp #131636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
BrianRothermich
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jul 22, 2025
…ndThenCatchesUp (elastic#131636) This addresses an unfounded test assumption that a merge following refreshes is a noop. Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the TieredMergePolicy is invoked again it might still find yet another merge to run. Fixes elastic#131262
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jul 22, 2025
…ndThenCatchesUp (elastic#131636) This addresses an unfounded test assumption that a merge following refreshes is a noop. Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the TieredMergePolicy is invoked again it might still find yet another merge to run. Fixes elastic#131262
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
…ndThenCatchesUp (#131636) (#131674) This addresses an unfounded test assumption that a merge following refreshes is a noop. Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the TieredMergePolicy is invoked again it might still find yet another merge to run. Fixes #131262
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
…ndThenCatchesUp (#131636) (#131676) This addresses an unfounded test assumption that a merge following refreshes is a noop. Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the TieredMergePolicy is invoked again it might still find yet another merge to run. Fixes #131262
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 22, 2025
…ndThenCatchesUp (#131636) (#131675) This addresses an unfounded test assumption that a merge following refreshes is a noop. Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the TieredMergePolicy is invoked again it might still find yet another merge to run. Fixes #131262
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 22, 2025
…king * upstream/main: (100 commits) Term vector API on stateless search nodes (elastic#129902) TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp (elastic#131636) Add inference.put_custom rest-api-spec (elastic#131660) ESQL: Fewer serverless docs in tests (elastic#131651) Skip search on indices with INDEX_REFRESH_BLOCK (elastic#129132) Mute org.elasticsearch.indices.cluster.RemoteSearchForceConnectTimeoutIT testTimeoutSetting elastic#131656 [jdk] Resolve EA OpenJDK builds to our JDK archive (elastic#131237) Add optimized path for intermediate values aggregator (elastic#131390) Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline (elastic#131236) Refresh potential lost connections at query start for `_search` (elastic#130463) Add template_id to patterned-text type (elastic#131401) Integrate LIKE/RLIKE LIST with ReplaceStringCasingWithInsensitiveRegexMatch rule (elastic#131531) [ES|QL] Add doc for the COMPLETION command (elastic#131010) ESQL: Add times to topn status (elastic#131555) ESQL: Add asynchronous pre-optimization step for logical plan (elastic#131440) ES|QL: Improve generative tests for FORK [130015] (elastic#131206) Update index mapping update privileges (elastic#130894) ESQL: Added Sample operator NamedWritable to plugin (elastic#131541) update `kibana_system` to grant it access to `.chat-*` system index (elastic#131419) Clarify heap size configuration (elastic#131607) ...
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jul 22, 2025
…-tracking * upstream/main: (44 commits) Term vector API on stateless search nodes (elastic#129902) TEST Fix ThreadPoolMergeSchedulerStressTestIT testMergingFallsBehindAndThenCatchesUp (elastic#131636) Add inference.put_custom rest-api-spec (elastic#131660) ESQL: Fewer serverless docs in tests (elastic#131651) Skip search on indices with INDEX_REFRESH_BLOCK (elastic#129132) Mute org.elasticsearch.indices.cluster.RemoteSearchForceConnectTimeoutIT testTimeoutSetting elastic#131656 [jdk] Resolve EA OpenJDK builds to our JDK archive (elastic#131237) Add optimized path for intermediate values aggregator (elastic#131390) Correctly handling download_database_on_pipeline_creation within a pipeline processor within a default or final pipeline (elastic#131236) Refresh potential lost connections at query start for `_search` (elastic#130463) Add template_id to patterned-text type (elastic#131401) Integrate LIKE/RLIKE LIST with ReplaceStringCasingWithInsensitiveRegexMatch rule (elastic#131531) [ES|QL] Add doc for the COMPLETION command (elastic#131010) ESQL: Add times to topn status (elastic#131555) ESQL: Add asynchronous pre-optimization step for logical plan (elastic#131440) ES|QL: Improve generative tests for FORK [130015] (elastic#131206) Update index mapping update privileges (elastic#130894) ESQL: Added Sample operator NamedWritable to plugin (elastic#131541) update `kibana_system` to grant it access to `.chat-*` system index (elastic#131419) Clarify heap size configuration (elastic#131607) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
Team:Distributed Indexing
Meta label for Distributed Indexing team
>test
Issues or PRs that are addressing/adding tests
v8.19.1
v9.0.5
v9.1.1
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an unfounded test assumption that a merge following refreshes is a noop.
Refreshes might trigger a merge, but segments can be part of a single merge task at a time so it's possible that after multiple independent merges finish, if the
TieredMergePolicy
is invoked again it might still find yet another merge to run.Fixes #131262