Skip to content

Rehydrate vectors at the deepest available object in the JSON path #131663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Rehydrate vectors at the deepest available object in the JSON path #131663

merged 2 commits into from
Jul 23, 2025

Conversation

@jimczi
Copy link
Contributor

@jimczi jimczi commented Jul 22, 2025

This change ensures that when restoring vectors removed from the source, we locate the deepest existing object along the JSON path to rehydrate them accurately.

@jimczi
Rehydrate vectors at the deepest available object in the JSON path
3bd7d50 
This change ensures that when restoring vectors removed from the source, we locate the deepest existing object along the JSON path to rehydrate them accurately.
@jimczi jimczi requested a review from a team as a code owner July 22, 2025 06:26
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 22, 2025
@jimczi jimczi requested review from Mikep86 and removed request for a team July 22, 2025 19:05
Mikep86
Mikep86 approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Non-blocking, but it would to add a test with ambiguity where failOnMultiMap is false.

@jimczi
Copy link
Contributor Author

jimczi commented Jul 23, 2025

Non-blocking, but it would to add a test with ambiguity where failOnMultiMap is false.

I added specific tests for this inside testInsertValueAmbiguousPath.

@jimczi jimczi merged commit 62de8a5 into elastic:main Jul 23, 2025
33 checks passed
@jimczi jimczi deleted the rehydrate_source_vectors_nested branch July 23, 2025 15:15
@Mikep86
Copy link
Contributor

Mikep86 commented Jul 23, 2025

I added specific tests for this inside testInsertValueAmbiguousPath.

Got it, missed that in all the refactored code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikep86 Mikep86 Mikep86 approved these changes

Assignees

No one assigned

Labels

>non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimczi @elasticsearchmachine @Mikep86