Skip to content

Increase delta in ESVectorUtilTests.testSoarDistance #131692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Increase delta in ESVectorUtilTests.testSoarDistance #131692

merged 1 commit into from
Jul 22, 2025

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Jul 22, 2025 •
edited
Loading

This commit increases the delta in ESVectorUtilTests.testSoarDistance, similar to what we do in other tests.

closes #131652

@ChrisHegarty
Increase delta in ESVectorUtilTests
18324bb 
This commit increases the delta in ESVectorUtilTests, similar to what we do in other tests.
@ChrisHegarty ChrisHegarty requested a review from iverase July 22, 2025 13:40
@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.0 labels Jul 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty
Copy link
Contributor Author

ChrisHegarty commented Jul 22, 2025 •
edited
Loading

Prior to this change, the following command fails very regularly. However, with this change the test appears stable.
./gradlew ":libs:simdvec:test" --rerun --tests "org.elasticsearch.simdvec.ESVectorUtilTests" -Dtests.iters=10000

@ChrisHegarty ChrisHegarty changed the title Increase delta in ESVectorUtilTests Increase delta in ESVectorUtilTests.testSoarDistance Jul 22, 2025
iverase
iverase approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty added the auto-backport Automatically create backport pull requests when merged label Jul 22, 2025
@ChrisHegarty ChrisHegarty merged commit 446942f into main Jul 22, 2025
33 of 34 checks passed
@ChrisHegarty ChrisHegarty deleted the ChrisHegarty-patch-2 branch July 22, 2025 15:02
@ChrisHegarty ChrisHegarty mentioned this pull request Jul 22, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.1

ChrisHegarty added a commit to ChrisHegarty/elasticsearch that referenced this pull request Jul 22, 2025
@ChrisHegarty
Increase delta in ESVectorUtilTests (elastic#131692)
bfb1bd9 
This commit increases the delta in ESVectorUtilTests.testSoarDistance, similar to what we do in other tests.
tteofili added a commit that referenced this pull request Sep 30, 2025
@ChrisHegarty @tteofili
Increase delta in ESVectorUtilTests (#131692) (#131700)
660fe82 
This commit increases the delta in ESVectorUtilTests.testSoarDistance, similar to what we do in other tests.

Co-authored-by: Tommaso Teofili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iverase iverase iverase approved these changes

@john-wagster john-wagster Awaiting requested review from john-wagster

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] ESVectorUtilTests testSoarDistance failing

3 participants

@ChrisHegarty @elasticsearchmachine @iverase