Skip to content

[ES|QL] Replace RoundTo linear search evaluator with manual evaluators #131733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 25, 2025
Merged

[ES|QL] Replace RoundTo linear search evaluator with manual evaluators #131733

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
93d43e9
replace linear search evaluator with manual evaluators
fang-xing-esql Jul 22, 2025
0066fab
[CI] Auto commit changes from spotless
Jul 22, 2025
e69dd01
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 22, 2025
ad06778
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 22, 2025
d914ae0
spotless
fang-xing-esql Jul 23, 2025
55de695
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 23, 2025
e6b4e5f
try to fix spotless
fang-xing-esql Jul 23, 2025
4af67be
try to fix spotless
fang-xing-esql Jul 23, 2025
5eb0a29
Try to fix spotless
fang-xing-esql Jul 23, 2025
c1013b4
exclude all files under generated-src from spotless
fang-xing-esql Jul 24, 2025
378660c
[CI] Auto commit changes from spotless
Jul 24, 2025
f247d79
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 24, 2025
186d172
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 24, 2025
b62fb3c
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 24, 2025
c7b5d8d
Update docs/changelog/131733.yaml
fang-xing-esql Jul 24, 2025
086dd8f
fix formatter
nik9000 Jul 24, 2025
728d247
add comments to the manual binary search methods
fang-xing-esql Jul 24, 2025
974e859
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 24, 2025
5bc1693
Merge branch 'main' into replace-roundto-linearsearch-with-manual-eva…
fang-xing-esql Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/131733.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 131733
summary: Replace `RoundTo` linear search evaluator with manual evaluators
area: ES|QL
type: enhancement
issues: []
2 changes: 1 addition & 1 deletion x-pack/plugin/esql/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ pluginManager.withPlugin('com.diffplug.spotless') {
targetExclude "src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseLexer*.java",
"src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseParser*.java",
"src/main/generated/**/*.java",
"src/main/generated-src/generated/**/*.java"
"src/main/generated-src/**/*.java"
Copy link
Member Author

@fang-xing-esql fang-xing-esql Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip the format check on all files under src/main/generated-src/, I don't see this subfolder src/main/generated-src/generated/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that we were running spotless on these - it forces us to write the templates in a way that keeps the style consistent. It's a pain though. Can you try removing this and fixing the templates? I know it's really picky and annoying. But it helps keep the code more readable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tricks!

toggleOffOn('begin generated imports', 'end generated imports')
}
}
Expand Down
218 changes: 202 additions & 16 deletions ...rated-src/org/elasticsearch/xpack/esql/expression/function/scalar/math/RoundToDouble.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading