Allow update any index type to bbq_disk #131760
Conversation
carlosdelest
added
>non-issue
:Search Relevance/Vectors
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
There was a problem hiding this comment.
I'm interested in other tests that we could do in YAML. I extended the ones we currently have to check that we can switch to bbq_disk.
There was a problem hiding this comment.
you might want to add "bbq_disk" (and perhaps "bbq_flat" and "bbq_hnsw"? with a random choice) to the updated cluster mapping in DenseVectorMappingUpdateIT.
There was a problem hiding this comment.
you might want to add "bbq_disk" (and perhaps "bbq_flat" and "bbq_hnsw"? with a random choice) to the updated cluster mapping in DenseVectorMappingUpdateIT
Thought about that - but IIUC the mapping is applied before the upgrade, so I'm not sure if the mapping will be supported by the older node 🤔
I believe we can create a separate IT test for updating the mapping and index / search, similar to what the YAML test does, but in a randomized manner. That would add coverage to the YAML tests and probably remove some of them.
I think that should be done as a separate PR - but happy to work on that if y'all think is worhtwhile 👍
| - method: POST | ||
| path: /_search | ||
| capabilities: [ optimized_scalar_quantization_bbq ] | ||
| capabilities: [ update_field_to_bbq_disk, dense_vector_updatable_bbq ] |
There was a problem hiding this comment.
I changed some capabilities, as they were referring to /_mapping instead of /_search - we were skipping some tests due to the capabilities not being present in _search.
There was a problem hiding this comment.
you might want to add "bbq_disk" (and perhaps "bbq_flat" and "bbq_hnsw"? with a random choice) to the updated cluster mapping in DenseVectorMappingUpdateIT.
|
Added more comprehensive update tests in #131821 |
4 participants
Allow updates from any index type to
bbq_disk.For the moment, no further restrictions have been applied to updating from
bbq_disktobbq_disk.Closes #131461