Skip to content

ESQL: Add docs to some Unresolved #131780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

ESQL: Add docs to some Unresolved #131780

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd1ce4c
ESQL: Add docs to some Unresolved
nik9000 Jul 23, 2025
6b8db44
Merge branch 'main' into esql_docs_for_unresolved
nik9000 Jul 23, 2025
df52faf
Merge branch 'main' into esql_docs_for_unresolved
nik9000 Jul 23, 2025
c8699bd
Typo
nik9000 Jul 23, 2025
f27adc4
Merge remote-tracking branch 'nik9000/esql_docs_for_unresolved' into …
nik9000 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/UnresolvedAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@
import java.util.List;
import java.util.Objects;

// unfortunately we can't use UnresolvedNamedExpression
/**
* An unresolved attribute. We build these while walking the syntax
* tree and then resolve them into other {@link Attribute} subclasses during
* analysis.
* <p>
* For example, ff they reference the data directly from lucene they'll be
Copy link
Contributor

@julian-elastic julian-elastic Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if

* {@link FieldAttribute}s. If they reference the results of another calculation
* they will be {@link ReferenceAttribute}s.
* </p>
*/
public class UnresolvedAttribute extends Attribute implements Unresolvable {
private final boolean customMessage;
private final String unresolvedMsg;
Expand Down
6 changes: 6 additions & 0 deletions ...ql/src/main/java/org/elasticsearch/xpack/esql/expression/function/UnresolvedFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
package org.elasticsearch.xpack.esql.expression.function;

import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.xpack.esql.analysis.Analyzer;
import org.elasticsearch.xpack.esql.core.capabilities.Unresolvable;
import org.elasticsearch.xpack.esql.core.capabilities.UnresolvedException;
import org.elasticsearch.xpack.esql.core.expression.Expression;
Expand All @@ -24,6 +25,11 @@
import java.util.Objects;
import java.util.Set;

/**
* An unresolved function call. We build these while walking the syntax
* tree and then resolve them into other {@link Function} subclasses during
* {@link Analyzer analysis}.
*/
public class UnresolvedFunction extends Function implements Unresolvable {

private final String name;
Expand Down