Upgrade MinIO (& work around bug) #131815
Conversation
Relates minio/minio#21456 Closes elastic#131742
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| // However the 2025-05-24 release is also buggy, see https://github.com/minio/minio/issues/21377, and this has no workaround | ||
| public static final String DOCKER_BASE_IMAGE = "minio/minio:RELEASE.2025-06-13T11-33-47Z"; | ||
| // NB releases earlier than 2025-05-24 are buggy, see https://github.com/minio/minio/issues/21189, and #127166 for a workaround. | ||
| // However the 2025-05-24 release is also buggy, see https://github.com/minio/minio/issues/21377, and this has no workaround. |
There was a problem hiding this comment.
minio/minio#21377 appears to be resolved. Is it mentioned here because it wasn't released in the 2025-07-23 build?
There was a problem hiding this comment.
No, that should be fixed in 2025-07-23. The specific MinIO version in use has come up in some conversations with customers so I'm keeping track of the known issues in older versions here. We may end up having to run these tests against multiple MinIO versions in which case we'll need this info - clearly we can extract it from history but it's going to be easier if we have a summary here.
There was a problem hiding this comment.
Okay, sounds good then 👍
| // NB releases earlier than 2025-05-24 are buggy, see https://github.com/minio/minio/issues/21189, and #127166 for a workaround | ||
| // However the 2025-05-24 release is also buggy, see https://github.com/minio/minio/issues/21377, and this has no workaround | ||
| public static final String DOCKER_BASE_IMAGE = "minio/minio:RELEASE.2025-06-13T11-33-47Z"; | ||
| // NB releases earlier than 2025-05-24 are buggy, see https://github.com/minio/minio/issues/21189, and #127166 for a workaround. |
There was a problem hiding this comment.
Is minio/minio#21189 mentioned because the bug wasn't fixed properly, leading to you filing 21456?
I'm wondering if it's worth mentioning resolved bugs. But if it still relates, then that seems helpful, maybe mentioned in that way.
There was a problem hiding this comment.
I'm not sure, I suspect minio/minio#21456 might be something different albeit with similar symptoms.
| .setting("xpack.security.enabled", "false") | ||
| // Skip listing of pre-existing uploads during a CAS because MinIO sometimes leaks them; also reduce the delay before proceeding | ||
| // TODO do not set these if running a MinIO version in which https://github.com/minio/minio/issues/21189 | ||
| // and https://github.com/minio/minio/issues/21456 are both fixed |
There was a problem hiding this comment.
Does minio/minio#21189 need to be mentioned, since it is closed already?
Also, should the testing change made in https://github.com/elastic/elasticsearch/pull/127166/files be returned, since the fix did not take? IIUC that minio/minio#21189 didn't actually fix the bug, leading to you filing minio/minio#21456?
There was a problem hiding this comment.
This is the testing change from #127166, it's just that we're applying it to the correct test suite here 🤦
There was a problem hiding this comment.
Ah 😄 Then we're good to go 🙃
DaveCTurner
added
the
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
Relates minio/minio#21456 Closes elastic#131742 Backport of elastic#131815 to 9.0
Relates minio/minio#21456 Closes elastic#131742 Backport of elastic#131815 to 9.0
Relates minio/minio#21456 Closes elastic#131742 Backport of elastic#131815 to 8.18
Relates minio/minio#21456 Closes #131742 Backport of #131815 to 9.0
Relates minio/minio#21456 Closes #131742 Backport of #131815 to 8.18
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in #131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in #131815.
Reverts workaround for minio/minio#21456 introduced in #131815.
Reverts workaround for minio/minio#21456 introduced in #131815.
Reverts workaround for minio/minio#21456 introduced in #131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
Reverts workaround for minio/minio#21456 introduced in elastic#131815.
…stic#134354) Reverts workaround for minio/minio#21456 introduced in elastic#131815.
…stic#134354) Reverts workaround for minio/minio#21456 introduced in elastic#131815.
3 participants
Relates minio/minio#21456
Closes #131742