Skip to content

Resolve inference release tests failing due to missing feature flag #131841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025
Merged

Resolve inference release tests failing due to missing feature flag #131841

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e79684f
Add Rerank snippet feature flag to inference integration tests
kderusso Jul 24, 2025
427e66c
Update to assume snapshot
kderusso Jul 24, 2025
918b01a
Merge branch 'main' into kderusso/fix-inference-it-for-snippets
kderusso Jul 24, 2025
54a946d
Only skip snippet tests instead of whole inference suite
kderusso Jul 24, 2025
fd6e96d
Fix automated checks
kderusso Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...in/inference/src/yamlRestTest/java/org/elasticsearch/xpack/inference/InferenceRestIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@

import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;

import org.elasticsearch.Build;
import org.elasticsearch.client.Request;
import org.elasticsearch.common.Strings;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.test.cluster.ElasticsearchCluster;
import org.elasticsearch.test.cluster.FeatureFlag;
import org.elasticsearch.test.cluster.local.distribution.DistributionType;
import org.elasticsearch.test.rest.yaml.ClientYamlTestCandidate;
import org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase;
Expand All @@ -21,6 +23,7 @@

import java.io.IOException;
import java.util.List;
import java.util.Locale;
import java.util.Map;

public class InferenceRestIT extends ESClientYamlSuiteTestCase {
Expand All @@ -31,12 +34,17 @@ public class InferenceRestIT extends ESClientYamlSuiteTestCase {
.setting("xpack.security.enabled", "false")
.setting("xpack.security.http.ssl.enabled", "false")
.setting("xpack.license.self_generated.type", "trial")
.feature(FeatureFlag.RERANK_SNIPPETS)
.plugin("inference-service-test")
.distribution(DistributionType.DEFAULT)
.build();

public InferenceRestIT(final ClientYamlTestCandidate testCandidate) {
super(testCandidate);
String testPath = testCandidate.getTestPath();
if (testPath.startsWith("inference/70_text_similarity_rank_retriever") && testPath.toLowerCase(Locale.ROOT).contains("snippet")) {
assumeTrue("Rerank snippets does not work in release builds", Build.current().isSnapshot());
}
}

@Override
Expand Down