Stabilize CancellableTasksIT#testRemoveBanParentsOnDisconnect #131858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiannaHohensee
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
force-pushed
the
2025/07/23/test-fix-131562
branch
from
daf8ebc to
784014f
Compare
Ensure that the cluster has a stably elected master node when the test completes so that the post-test tear-down check for cluster state consistency can succeed. Closes elastic#131562
DiannaHohensee
force-pushed
the
2025/07/23/test-fix-131562
branch
from
784014f to
d6e1883
Compare
joshua-adams-1
approved these changes
Aug 4, 2025
| allowEntireRequest(rootRequest); | ||
| cancelFuture.actionGet(); | ||
| ensureBansAndCancellationsConsistency(); | ||
| // This method will call the cluster health API with wait_for_tasks set to Priority#LANGUID. This will ensure that all tasks |
There was a problem hiding this comment.
Did you run this test X times to verify this indeed fixes any race conditions? (Only that since we've unmuted the test, it would be silly if it failed again in two days)
There was a problem hiding this comment.
Thanks for checking. I realize that the context isn't all there in the git issue: some of the discussion occurred in slack.
I just went ahead and ran it successfully locally on my machine a dozen or so times. It's hard to confirm, since failures usually occur under stressed concurrency conditions.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Aug 6, 2025
…cking * upstream/main: (24 commits) Revert "[Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400)" (elastic#132499) ESQL: Rename evaluators for FIRST and LAST (elastic#132466) Add inference fields to semantic text docs (elastic#132471) ESQL: Allow FIRST and LAST as method name (elastic#132469) ESQL: Add javadoc for PushDownAndCombineFilters (elastic#132484) Misc cleanups in Coordinator (elastic#132452) [DiskBBQ] Write the maximum posting list size to avoid resizing the docId array (elastic#132447) Improve exception handling for JsonXContentParser (elastic#123439) Clarify quantization on semantic_text BBQ dense vector default (elastic#132470) Fix test infra NPE in doEnsureClusterStateConsistency (elastic#131859) Stabilize CancellableTasksIT#testRemoveBanParentsOnDisconnect (elastic#131858) Move ClusterApplierService assertion after logging exception (elastic#132446) ESQL: Support for multi-argument aggs (elastic#132424) Update wolfi (versioned) (elastic#132457) ESQL: Fix Function javadoc (elastic#132399) [ML] Inference API disable partial search results (elastic#132362) Unmute testTermsQuery tests (elastic#132409) Fix index lookup when field-caps returns empty mapping (elastic#132138) CompressorFactory.compressor (elastic#132448) ESQL add formatting to plans in javadoc (elastic#132421) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the cluster has a stably elected master node
when the test completes so that the post-test tear-down
check for cluster state consistency across nodes can
succeed.
Closes #131562