Skip to content

Conversation

@DiannaHohensee
Copy link
Contributor

@DiannaHohensee DiannaHohensee commented Jul 24, 2025

Adds an assertion that an elected master was
found in the cluster state. Adds a clearer failure
explanation than a NullPointerException.

Relates #131562


Instead of seeing

Caused by: java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because "masterId" is null

we'll see the new assertion "Unable to find master in cluster state. Expecting a stable master node"

@DiannaHohensee DiannaHohensee self-assigned this Jul 24, 2025
@DiannaHohensee DiannaHohensee added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0 labels Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Contributor

@joshua-adams-1 joshua-adams-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DiannaHohensee DiannaHohensee merged commit e5a37b0 into elastic:main Aug 5, 2025
33 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 6, 2025
…cking

* upstream/main: (24 commits)
  Revert "[Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400)" (elastic#132499)
  ESQL: Rename evaluators for FIRST and LAST (elastic#132466)
  Add inference fields to semantic text docs (elastic#132471)
  ESQL: Allow FIRST and LAST as method name (elastic#132469)
  ESQL: Add javadoc for PushDownAndCombineFilters (elastic#132484)
  Misc cleanups in Coordinator (elastic#132452)
  [DiskBBQ] Write the maximum posting list size to avoid resizing the docId array (elastic#132447)
  Improve exception handling for JsonXContentParser (elastic#123439)
  Clarify quantization on semantic_text BBQ dense vector default (elastic#132470)
  Fix test infra NPE in doEnsureClusterStateConsistency (elastic#131859)
  Stabilize CancellableTasksIT#testRemoveBanParentsOnDisconnect (elastic#131858)
  Move ClusterApplierService assertion after logging exception (elastic#132446)
  ESQL: Support for multi-argument aggs (elastic#132424)
  Update wolfi (versioned) (elastic#132457)
  ESQL: Fix Function javadoc (elastic#132399)
  [ML] Inference API disable partial search results (elastic#132362)
  Unmute testTermsQuery tests (elastic#132409)
  Fix index lookup when field-caps returns empty mapping (elastic#132138)
  CompressorFactory.compressor (elastic#132448)
  ESQL add formatting to plans in javadoc (elastic#132421)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants