[ML] Adjust test case values due to changed memory reporting #131981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ml-cpp PR elastic/ml-cpp#2846 introduces changes to how memory values are calculated and reported for Linux platforms. This PR adjusts test case values accordingly.
edsavage
added
>non-issue
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Jul 31, 2025
…#131981) The ml-cpp PR elastic/ml-cpp#2846 introduces changes to how memory values are calculated and reported for Linux platforms. This PR adjusts test case values accordingly.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jul 31, 2025
…#131981) The ml-cpp PR elastic/ml-cpp#2846 introduces changes to how memory values are calculated and reported for Linux platforms. This PR adjusts test case values accordingly.
valeriy42
added a commit
that referenced
this pull request
Oct 31, 2025
…nd improve model size assertions (#135526) Previously, the upper bound for model memory checks was set in absolute terms, which is not easy to understand and is brittle. I adjusted the assertions to ensure that the memory usage does not exceed 5% of the memory limit. Additionally, on Linux, we now report the process size (see #131981), which includes approximately 20 MB of native code overhead. I made handling this overhead more explicit. More details: Removed muted tests for testManyDistinctOverFields and testTooManyByAndOverFields. Introduced constants for memory limits in AutodetectMemoryLimitIT. Updated assertions to check effective model size against calculated limits. Closes #132308 Closes #132310 Closes #132611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ml-cpp PR elastic/ml-cpp#2846 introduces changes to how memory values are calculated and reported for Linux platforms. This PR adjusts test case values accordingly.