Skip to content

[9.1.1] Turn direct IO off by default #132002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2025
Merged

[9.1.1] Turn direct IO off by default #132002

merged 5 commits into from
Jul 31, 2025

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jul 28, 2025 •
edited by ChrisHegarty
Loading

Direct IO is off by default in main, but not in 9.1.

relates #130014

@thecoop thecoop requested a review from ChrisHegarty July 28, 2025 10:41
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added v9.1.1 Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Jul 28, 2025
@thecoop thecoop changed the title Turn direct IO off by default [9.1Turn direct IO off by default Jul 28, 2025
@thecoop thecoop changed the title [9.1Turn direct IO off by default [9.1 Turn direct IO off by default Jul 28, 2025
@thecoop thecoop changed the title [9.1 Turn direct IO off by default [9.1] Turn direct IO off by default Jul 28, 2025
@jozala
Copy link
Contributor

jozala commented Jul 28, 2025

Hi @thecoop . Could you please confirm that because this is set properly on main, then this is a blocker only for stateful?

@thecoop thecoop mentioned this pull request Jul 28, 2025
Merged
ChrisHegarty
ChrisHegarty approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty changed the title [9.1] Turn direct IO off by default [9.1.1] Turn direct IO off by default Jul 29, 2025
@thecoop thecoop merged commit 27b1522 into elastic:9.1 Jul 31, 2025
34 checks passed
@thecoop thecoop deleted the 9.1-direct-io-off branch July 31, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

No one assigned

Labels

>non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thecoop @elasticsearchmachine @jozala @ChrisHegarty