Master node disconnect #132023
+344
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| package org.elasticsearch.cluster.coordination; | ||
|
|
||
| import org.elasticsearch.action.ActionListener; | ||
| import org.elasticsearch.cluster.ClusterStateApplier; | ||
| import org.elasticsearch.cluster.node.DiscoveryNode; | ||
| import org.elasticsearch.cluster.service.ClusterService; | ||
| import org.elasticsearch.core.Releasable; | ||
| import org.elasticsearch.test.ClusterServiceUtils; | ||
| import org.elasticsearch.test.ESIntegTestCase; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.concurrent.CountDownLatch; | ||
| import java.util.concurrent.CyclicBarrier; | ||
|
|
||
| /** | ||
| * An integration test base class to be used when a test requires a master re-election | ||
| */ | ||
| public abstract class MasterElectionTestCase extends ESIntegTestCase { | ||
|
|
||
| /** | ||
| * Block the cluster state applier on a node. Returns only when applier is blocked. | ||
| * | ||
| * @param nodeName The name of the node on which to block the applier | ||
| * @param cleanupTasks The list of clean up tasks | ||
| * @return A cyclic barrier which when awaited on will un-block the applier | ||
| */ | ||
| protected static CyclicBarrier blockClusterStateApplier(String nodeName, ArrayList<Releasable> cleanupTasks) { | ||
| final var stateApplierBarrier = new CyclicBarrier(2); | ||
| internalCluster().getInstance(ClusterService.class, nodeName).getClusterApplierService().onNewClusterState("test", () -> { | ||
| // Meet to signify application is blocked | ||
| safeAwait(stateApplierBarrier); | ||
| // Wait for the signal to unblock | ||
| safeAwait(stateApplierBarrier); | ||
| return null; | ||
| }, ActionListener.noop()); | ||
| cleanupTasks.add(stateApplierBarrier::reset); | ||
|
|
||
| // Wait until state application is blocked | ||
| safeAwait(stateApplierBarrier); | ||
| return stateApplierBarrier; | ||
| } | ||
|
|
||
| /** | ||
| * Configure a latch that will be released when the existing master knows of the new master's election | ||
| * | ||
| * @param newMaster The name of the newMaster node | ||
| * @param cleanupTasks The list of cleanup tasks | ||
| * @return A latch that will be released when the old master acknowledges the new master's election | ||
| */ | ||
| protected CountDownLatch configureElectionLatchForNewMaster(String newMaster, List<Releasable> cleanupTasks) { | ||
|
||
| final String originalMasterName = internalCluster().getMasterName(); | ||
| logger.info("Original master was {}, new master will be {}", originalMasterName, newMaster); | ||
| final var previousMasterKnowsNewMasterIsElectedLatch = new CountDownLatch(1); | ||
| ClusterStateApplier newMasterMonitor = event -> { | ||
| DiscoveryNode masterNode = event.state().nodes().getMasterNode(); | ||
| if (masterNode != null && masterNode.getName().equals(newMaster)) { | ||
| previousMasterKnowsNewMasterIsElectedLatch.countDown(); | ||
| } | ||
| }; | ||
| ClusterService originalMasterClusterService = internalCluster().getInstance(ClusterService.class, originalMasterName); | ||
| originalMasterClusterService.addStateApplier(newMasterMonitor); | ||
| cleanupTasks.add(() -> originalMasterClusterService.removeApplier(newMasterMonitor)); | ||
| return previousMasterKnowsNewMasterIsElectedLatch; | ||
| } | ||
|
|
||
| /** | ||
| * Configure a latch that will be released when the existing master knows it has been re-elected | ||
| * | ||
| * @param masterNodeName The name of the current master node | ||
| * @param electedTerm The term the current master node was elected | ||
| * @param cleanupTasks The list of cleanup tasks | ||
| * @return A latch that will be released when the master acknowledges it's re-election | ||
| */ | ||
| protected CountDownLatch configureElectionLatchForReElectedMaster( | ||
|
||
| String masterNodeName, | ||
| long electedTerm, | ||
| List<Releasable> cleanupTasks | ||
| ) { | ||
| final var masterKnowsItIsReElectedLatch = new CountDownLatch(1); | ||
| ClusterStateApplier newMasterMonitor = event -> { | ||
| DiscoveryNode masterNode = event.state().nodes().getMasterNode(); | ||
| long currentTerm = event.state().coordinationMetadata().term(); | ||
| if (masterNode != null && masterNode.getName().equals(masterNodeName) && currentTerm > electedTerm) { | ||
| logger.info("Master knows it's re-elected"); | ||
| masterKnowsItIsReElectedLatch.countDown(); | ||
| } | ||
| }; | ||
| ClusterService masterClusterService = internalCluster().getInstance(ClusterService.class, masterNodeName); | ||
| masterClusterService.addStateApplier(newMasterMonitor); | ||
| cleanupTasks.add(() -> masterClusterService.removeApplier(newMasterMonitor)); | ||
| return masterKnowsItIsReElectedLatch; | ||
| } | ||
|
|
||
| /** | ||
| * Add some master-only nodes and block until they've joined the cluster | ||
| * <p> | ||
| * Ensure that we've got 5 voting nodes in the cluster, this means even if the original | ||
| * master accepts its own failed state update before standing down, we can still | ||
| * establish a quorum without its (or our own) join. | ||
| */ | ||
| protected static String ensureSufficientMasterEligibleNodes() { | ||
|
||
| final var votingConfigSizeListener = ClusterServiceUtils.addTemporaryStateListener( | ||
| cs -> 5 <= cs.coordinationMetadata().getLastCommittedConfiguration().getNodeIds().size() | ||
| ); | ||
|
|
||
| try { | ||
| final var newNodeNames = internalCluster().startMasterOnlyNodes(Math.max(1, 5 - internalCluster().numMasterNodes())); | ||
| safeAwait(votingConfigSizeListener); | ||
| return newNodeNames.get(0); | ||
| } finally { | ||
| votingConfigSizeListener.onResponse(null); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't think you need to pull this one up to the base class, it only has one caller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in a668ab1