Skip to content

Use UTF strings in data generation #132028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

Use UTF strings in data generation #132028

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db8c5fb
Use unicode strings in data generation by default
jordan-powers Jul 28, 2025
be316af
Merge remote-tracking branch 'upstream/main' into data-generation-utf…
jordan-powers Jul 28, 2025
a2580a6
Avoid generating invalid field names
jordan-powers Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...main/java/org/elasticsearch/datageneration/datasource/DefaultObjectGenerationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import java.util.Optional;
import java.util.Set;

import static org.elasticsearch.test.ESTestCase.randomAlphaOfLengthBetween;
import static org.elasticsearch.test.ESTestCase.randomDouble;
import static org.elasticsearch.test.ESTestCase.randomIntBetween;
import static org.elasticsearch.test.ESTestCase.randomRealisticUnicodeOfCodepointLengthBetween;

public class DefaultObjectGenerationHandler implements DataSourceHandler {
@Override
Expand Down Expand Up @@ -49,7 +49,7 @@ public boolean generateRegularSubObject() {

@Override
public String generateFieldName() {
return randomAlphaOfLengthBetween(1, 10);
return randomRealisticUnicodeOfCodepointLengthBetween(1, 10);
}
};
}
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/org/elasticsearch/datageneration/datasource/DefaultPrimitiveTypesHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public DataSourceResponse.HalfFloatGenerator handle(DataSourceRequest.HalfFloatG

@Override
public DataSourceResponse.StringGenerator handle(DataSourceRequest.StringGenerator request) {
return new DataSourceResponse.StringGenerator(() -> ESTestCase.randomAlphaOfLengthBetween(0, 50));
return new DataSourceResponse.StringGenerator(() -> ESTestCase.randomRealisticUnicodeOfCodepointLengthBetween(0, 50));
}

@Override
Expand Down