Relocate RemoteClusterService methods only used in tests.
#132037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change eliminates or moves the following methods from RemoteClusterService: isCrossClusterSearchEnabled() isRemoteNodeConnected() isRemoteClusterRegistered() This is part of an effort to reduce the API surface area of RemoteClusterService. Relates: elastic#131894, elastic#131948
JeremyDahlgren
added
>refactoring
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
approved these changes
Jul 29, 2025
server/src/test/java/org/elasticsearch/transport/RemoteClusterServiceTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/transport/RemoteClusterClientTests.java
Outdated
Show resolved
Hide resolved
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Jul 31, 2025
…132037) This change eliminates or moves the following methods from RemoteClusterService: isCrossClusterSearchEnabled() isRemoteNodeConnected() isRemoteClusterRegistered() This is part of an effort to reduce the API surface area of RemoteClusterService. Relates: elastic#131894, elastic#131948
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jul 31, 2025
…132037) This change eliminates or moves the following methods from RemoteClusterService: isCrossClusterSearchEnabled() isRemoteNodeConnected() isRemoteClusterRegistered() This is part of an effort to reduce the API surface area of RemoteClusterService. Relates: elastic#131894, elastic#131948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates or moves the following methods from
RemoteClusterService:isCrossClusterSearchEnabled()isRemoteNodeConnected()isRemoteClusterRegistered()This is part of an effort to reduce the API surface area of
RemoteClusterServiceand ease the analysis for makingRemoteClusterServicemulti-project aware.Relates: #131894, #131948