Skip to content

Fix testCloseOrReallocateDuringPartialSnapshot #132049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

Fix testCloseOrReallocateDuringPartialSnapshot #132049

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f96c727
Fix testCloseOrReallocateDuringPartialSnapshot
DiannaHohensee Jul 28, 2025
83ea094
Merge branch 'main' into 2025/07/28/fix-131900
DiannaHohensee Jul 31, 2025
bd88e3f
Merge branch 'main' into 2025/07/28/fix-131900
DiannaHohensee Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .../internalClusterTest/java/org/elasticsearch/snapshots/SharedClusterSnapshotRestoreIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,12 +1447,11 @@ public void run() {
safeAwait(barrier);

final var snapshotName = randomIdentifier();
final var partialSnapshot = randomBoolean();
ActionFuture<CreateSnapshotResponse> snapshotFuture = clusterAdmin().prepareCreateSnapshot(
TEST_REQUEST_TIMEOUT,
repoName,
snapshotName
).setIndices(indexName).setWaitForCompletion(true).setPartial(partialSnapshot).execute();
).setIndices(indexName).setWaitForCompletion(true).setPartial(true).execute();

// we have currently blocked the start-snapshot task from running, and it will be followed by at least three blob uploads
// (segments_N, .cfe, .cfs), executed one-at-a-time because of throttling to the max threadpool size, so it's safe to let up to
Expand All @@ -1466,7 +1465,7 @@ public void run() {
assertFalse(snapshotFuture.isDone());

try {
if (partialSnapshot && randomBoolean()) {
if (randomBoolean()) {
logger.info("--> closing index [{}]", indexName);
safeGet(indicesAdmin().prepareClose(indexName).execute());
ensureGreen(indexName);
Expand Down