Make ToDouble sealed interface #132053
Open
Make ToDouble sealed interface #132053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| * but it gets the job done for now. | ||
| */ | ||
| public interface ToDouble { | ||
| public sealed interface ToDouble permits SortableLongToDouble, SortableIntToFloat, SortableShortToHalfFloat, LongToScaledFloat { |
Contributor
There was a problem hiding this comment.
NIT: I do not think we need permits when all implementations are in the same file, do we?
| /** | ||
| * Convert from the stored {@link long} into the {@link double} to load. | ||
| * Sadly, this will go megamorphic pretty quickly and slow us down, | ||
| * but it gets the job done for now. |
Contributor
There was a problem hiding this comment.
Is this change enough to prevent megamorphic call?
Member
There was a problem hiding this comment.
I'd have expected that you'd need to make a copy of read(BlockFactory factory, Docs docs, int offset) for each one. but I could certainly be wrong here.
idegtiarenko
approved these changes
Jul 29, 2025
Contributor
idegtiarenko
left a comment
idegtiarenko
left a comment
There was a problem hiding this comment.
I do not mind the change, however I am interested to know if that actually improves the benchmark
Member
|
@dnhatn Are you planning to merge this? I think this would be beneficial, especially in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a time-series benchmark and saw overhead when converting longs to doubles. This change removes the TODO and implements the sealed interface for ToDouble.