Skip to content

Conversation

@carlosdelest
Copy link
Member

Mutes lucene_snapshot nested knn tests until #131749 is solved

@carlosdelest carlosdelest added >test-mute Use for PR that only mute tests :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch lucene_10_3_dev Tracking issue that arise during the development of Lucene 10.3 labels Jul 29, 2025
@carlosdelest carlosdelest marked this pull request as ready for review July 29, 2025 14:32
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@carlosdelest
Copy link
Member Author

@elasticmachine test this please

@carlosdelest carlosdelest added >test-mute Use for PR that only mute tests and removed >test-mute Use for PR that only mute tests labels Jul 29, 2025
@carlosdelest carlosdelest marked this pull request as ready for review July 29, 2025 16:22
@ChrisHegarty
Copy link
Contributor

The CI seems to be running a subset of tests or something, no ? For example, I expect one scenario of VectorNestedIT to fail, but I don't see it in this PR or test failures.

@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests and removed >test-mute Use for PR that only mute tests labels Jul 29, 2025
@carlosdelest
Copy link
Member Author

@elasticmachine test this please

@carlosdelest carlosdelest requested review from a team as code owners July 30, 2025 10:54
@carlosdelest carlosdelest requested a review from a team as a code owner July 30, 2025 10:54
@carlosdelest
Copy link
Member Author

@ChrisHegarty I believe the remaining tests failing should be taken care of as a separate issue / PR. WDYT?

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@carlosdelest carlosdelest merged commit 9714077 into elastic:lucene_snapshot Jul 30, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lucene_10_3_dev Tracking issue that arise during the development of Lucene 10.3 :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants