Skip to content

Mutes knn nested tests - #131749 #132087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 30, 2025
Merged

Mutes knn nested tests - #131749 #132087

merged 10 commits into from
Jul 30, 2025

Conversation

@carlosdelest
Copy link
Member

Mutes lucene_snapshot nested knn tests until #131749 is solved

@carlosdelest carlosdelest added >test-mute Use for PR that only mute tests :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch lucene_10_3_dev Tracking issue that arise during the development of Lucene 10.3 labels Jul 29, 2025
@carlosdelest carlosdelest marked this pull request as ready for review July 29, 2025 14:32
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@carlosdelest carlosdelest mentioned this pull request Jul 29, 2025
Closed
@carlosdelest carlosdelest marked this pull request as draft July 29, 2025 15:16
@carlosdelest
Copy link
Member Author

@elasticmachine test this please

@carlosdelest carlosdelest added >test-mute Use for PR that only mute tests and removed >test-mute Use for PR that only mute tests labels Jul 29, 2025
@carlosdelest carlosdelest marked this pull request as ready for review July 29, 2025 16:22
@ChrisHegarty
Copy link
Contributor

The CI seems to be running a subset of tests or something, no ? For example, I expect one scenario of VectorNestedIT to fail, but I don't see it in this PR or test failures.

@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests and removed >test-mute Use for PR that only mute tests labels Jul 29, 2025
@carlosdelest
Copy link
Member Author

@elasticmachine test this please

@carlosdelest carlosdelest requested review from a team as code owners July 30, 2025 10:54
@carlosdelest carlosdelest requested a review from a team as a code owner July 30, 2025 10:54
@github-actions
Copy link
Contributor

🔍 Preview links for changed docs

@carlosdelest
Copy link
Member Author

@ChrisHegarty I believe the remaining tests failing should be taken care of as a separate issue / PR. WDYT?

ChrisHegarty
ChrisHegarty approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@carlosdelest carlosdelest merged commit 9714077 into elastic:lucene_snapshot Jul 30, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

@thecoop thecoop Awaiting requested review from thecoop

Assignees

No one assigned

Labels

lucene_10_3_dev Tracking issue that arise during the development of Lucene 10.3 :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosdelest @elasticsearchmachine @ChrisHegarty